Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add blog post for Separate Image Filesystem for Kubelet #43971

Merged
merged 2 commits into from
Jan 23, 2024
Merged

Add blog post for Separate Image Filesystem for Kubelet #43971

merged 2 commits into from
Jan 23, 2024

Conversation

kannon92
Copy link
Contributor

Kubernetes has had support for many releases for a separate image filesystem. There are common configuration issues that users can do to get into a separate filesystem case. This post walks through configurations and the eviction manager.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. area/blog Issues or PRs related to the Kubernetes Blog subproject language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Nov 16, 2023
@kannon92
Copy link
Contributor Author

/cc @rphillips @haircommander for the technical review

@k8s-ci-robot
Copy link
Contributor

@kannon92: GitHub didn't allow me to request PR reviews from the following users: the, technical, review, for.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @rphillips @haircommander for the technical review

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@netlify Netlify
Copy link

netlify bot commented Nov 16, 2023

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 4cd2987
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/65566ff104539e000834558c
😎 Deploy Preview https://deploy-preview-43971--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Nov 16, 2023 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 82a00f8
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/65afbd0c053b230008a64153
😎 Deploy Preview https://deploy-preview-43971--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@haircommander
Copy link
Contributor

content looks good, I'd recommend some sort of conclusion though, the blog feels like it ends abruptly to me

@kannon92
Copy link
Contributor Author

content looks good, I'd recommend some sort of conclusion though, the blog feels like it ends abruptly to me

Thanks for that suggestion. I'll put on future work and suggest ways to get involved.

@kannon92
Copy link
Contributor Author

content looks good, I'd recommend some sort of conclusion though, the blog feels like it ends abruptly to me

Updated with some future work and a getting involved.

@dipesh-rawat
Copy link
Member

/sig node

@k8s-ci-robot k8s-ci-robot added the sig/node Categorizes an issue or PR as relevant to SIG Node. label Nov 17, 2023
@kannon92 kannon92 requested a review from sftim January 9, 2024 18:50
@kannon92
Copy link
Contributor Author

kannon92 commented Jan 9, 2024

@sftim I believe I addressed all your feedback.

colossus06
colossus06 suggested changes Jan 12, 2024
View reviewed changes
Copy link
Contributor

@colossus06 colossus06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A well-written blog, both in terms of readability and overall structure.
Here are my suggestions:

content/en/blog/_posts/2024-01-08-image-filesystem.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2024-01-08-image-filesystem.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2024-01-08-image-filesystem.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2024-01-08-image-filesystem.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2024-01-08-image-filesystem.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2024-01-08-image-filesystem.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2024-01-08-image-filesystem.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2024-01-08-image-filesystem.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2024-01-08-image-filesystem.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2024-01-08-image-filesystem.md Outdated Show resolved Hide resolved
@kannon92 kannon92 force-pushed the separate-filesystem-blog branch 2 times, most recently from b1225ff to 0bca3ef Compare January 12, 2024 21:30
sftim
sftim reviewed Jan 14, 2024
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi; a few more things to fix.

Also, could you bump the publication date back to the 23rd of January?

/hold
pending the change of publication date.

content/en/blog/_posts/2024-01-08-image-filesystem.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2024-01-08-image-filesystem.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2024-01-08-image-filesystem.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2024-01-08-image-filesystem.md Outdated Show resolved Hide resolved
@kannon92 @sftim
add a blog post on the separate image filesystem
2ecd7eb 
Co-authored-by: Krzysztof Wilczyński <kw@linux.com>

Co-authored-by: Tim Bannister <tim@scalefactory.com>
@kannon92
Copy link
Contributor Author

/retest

@kannon92
Copy link
Contributor Author

/hold cancel

@sftim this is ready for a review again. Updated the date so I think its good to go.

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 18, 2024
@kannon92
Copy link
Contributor Author

Not sure why the deploy failed though.

@kannon92
Copy link
Contributor Author

@sftim Looks like we have today and tomorrow to merge if we want to keep the due date. Any outstanding issues?

@kannon92 kannon92 mentioned this pull request Jan 22, 2024
Merged
@sftim
Copy link
Contributor

sftim commented Jan 23, 2024

This PR isn't previewing, which is a shame.
If you push an almost identical commit in place of what's there, that might help (#43736 tracks a proper fix)

@sftim
Copy link
Contributor

sftim commented Jan 23, 2024

Thanks

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 23, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: a6ede7193b9e3ac263177fd1327bd1365880eac7

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 23, 2024
@sftim
Copy link
Contributor

sftim commented Jan 23, 2024

Hi, Tide.

@k8s-ci-robot k8s-ci-robot merged commit e739bc3 into kubernetes:main Jan 23, 2024
6 checks passed
@kwilczynski kwilczynski mentioned this pull request Jun 21, 2024
Open
15 tasks
@kwilczynski kwilczynski mentioned this pull request Jul 22, 2024
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fuweid fuweid fuweid left review comments

@samuelkarp samuelkarp samuelkarp left review comments

@kwilczynski kwilczynski kwilczynski left review comments

@nate-double-u nate-double-u Awaiting requested review from nate-double-u

@onlydole onlydole Awaiting requested review from onlydole

@rphillips rphillips Awaiting requested review from rphillips

@haircommander haircommander Awaiting requested review from haircommander

@dipesh-rawat dipesh-rawat Awaiting requested review from dipesh-rawat

@colossus06 colossus06 Awaiting requested review from colossus06

@sftim sftim Awaiting requested review from sftim

Assignees

@sftim sftim

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/blog Issues or PRs related to the Kubernetes Blog subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/node Categorizes an issue or PR as relevant to SIG Node. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
SIG Docs Blog Project Board
Status: Published
SIG Node: code and documentation PRs
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@kannon92 @k8s-ci-robot @haircommander @dipesh-rawat @sftim @kwilczynski @samuelkarp @fuweid @colossus06