Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal for the Polish translation of the 'Download Kubernetes' section #43952

Merged
merged 1 commit into from
Nov 25, 2023

Conversation

adampuchejda
Copy link
Contributor

@adampuchejda adampuchejda commented Nov 15, 2023

Proposal for the Polish translation of the 'Download Kubernetes' section.

PL translation of the 'Download Kubernetes' (download.md) section. Pushing to the main branch in the absence of the dev-pl localization branch.

Copy link

linux-foundation-easycla bot commented Nov 15, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: adampuchejda / name: Adam Puchejda (0331fec)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Nov 15, 2023
@k8s-ci-robot
Copy link
Contributor

Welcome @adampuchejda!

It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/website has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. language/pl Issues or PRs related to Polish language labels Nov 15, 2023
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Nov 15, 2023
Copy link

netlify bot commented Nov 15, 2023

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 0331fec
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/655f0e846313090008824027
😎 Deploy Preview https://deploy-preview-43952--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Nov 15, 2023
@sftim
Copy link
Contributor

sftim commented Nov 15, 2023

/kind feature

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Nov 15, 2023
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, but: this isn't up to date with the English original.

Comment on lines 38 to 40
Odnośniki do plików binarnych z komponentami Kubernetesa (i ich sumy kontrolne) znajdziesz w [CHANGELOGU](https://github.com/kubernetes/kubernetes/tree/master/CHANGELOG).

Możesz też skorzystać ze strony [downloadkubernetes.com](https://www.downloadkubernetes.com/), gdzie szukane komponenty możesz filtrować w zależności od wersji i architektury sprzętowej.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Odnośniki do plików binarnych z komponentami Kubernetesa (i ich sumy kontrolne) znajdziesz w [CHANGELOGU](https://github.com/kubernetes/kubernetes/tree/master/CHANGELOG).
Możesz też skorzystać ze strony [downloadkubernetes.com](https://www.downloadkubernetes.com/), gdzie szukane komponenty możesz filtrować w zależności od wersji i architektury sprzętowej.
{{< release-binaries >}}

(and then verify that you've added all the relevant strings into data/i18n/pl/pl.toml)

Copy link
Contributor Author

@adampuchejda adampuchejda Nov 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @sftim! Thank you for catching this difference; I had clearly overlooked the change in the English version. I've made the correction and - in a new PR, following - included an updated and cleaned Polish version of the i18n file (/data/i18n/pl/pl.toml). @mfilocha, please take a look as well! Very best, Adam

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should change with the new data/i118n/pl/pl.toml file pushed which will happen shortly. I just need to do some cleaning.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(still looks like missing strings to me - look for English text)

Copy link
Contributor Author

@adampuchejda adampuchejda Nov 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for patience @sftim. With this addition #44054 the release-binaries part should be fine. Please check in your spare time.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 22, 2023
@mfilocha
Copy link
Contributor

Thanks, @adampuchejda! Could you please squash all commits into one: https://kubernetes.io/docs/contribute/new-content/open-a-pr/#squashing-commits

@adampuchejda adampuchejda reopened this Nov 22, 2023
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 22, 2023
@adampuchejda
Copy link
Contributor Author

@mfilocha Now, it should be fine. Thanks :)

@mfilocha mfilocha self-assigned this Nov 25, 2023
@mfilocha
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 25, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 9137b59d668ca5587d3f58a4c46f0b0f918f89e1

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mfilocha

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 25, 2023
@k8s-ci-robot k8s-ci-robot merged commit 47c026a into kubernetes:main Nov 25, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. language/pl Issues or PRs related to Polish language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants