-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposal for the Polish translation of the 'Download Kubernetes' section #43952
Conversation
|
Welcome @adampuchejda! |
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
/kind feature |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, but: this isn't up to date with the English original.
content/pl/releases/download.md
Outdated
Odnośniki do plików binarnych z komponentami Kubernetesa (i ich sumy kontrolne) znajdziesz w [CHANGELOGU](https://github.com/kubernetes/kubernetes/tree/master/CHANGELOG). | ||
|
||
Możesz też skorzystać ze strony [downloadkubernetes.com](https://www.downloadkubernetes.com/), gdzie szukane komponenty możesz filtrować w zależności od wersji i architektury sprzętowej. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Odnośniki do plików binarnych z komponentami Kubernetesa (i ich sumy kontrolne) znajdziesz w [CHANGELOGU](https://github.com/kubernetes/kubernetes/tree/master/CHANGELOG). | |
Możesz też skorzystać ze strony [downloadkubernetes.com](https://www.downloadkubernetes.com/), gdzie szukane komponenty możesz filtrować w zależności od wersji i architektury sprzętowej. | |
{{< release-binaries >}} |
(and then verify that you've added all the relevant strings into data/i18n/pl/pl.toml
)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @sftim! Thank you for catching this difference; I had clearly overlooked the change in the English version. I've made the correction and - in a new PR, following - included an updated and cleaned Polish version of the i18n file (/data/i18n/pl/pl.toml). @mfilocha, please take a look as well! Very best, Adam
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you happy with https://deploy-preview-43952--kubernetes-io-main-staging.netlify.app/pl/releases/download/#pliki-binarne? I think there might be some strings missing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should change with the new data/i118n/pl/pl.toml file pushed which will happen shortly. I just need to do some cleaning.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(still looks like missing strings to me - look for English text)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @adampuchejda! Could you please squash all commits into one: https://kubernetes.io/docs/contribute/new-content/open-a-pr/#squashing-commits |
@mfilocha Now, it should be fine. Thanks :) |
/lgtm |
LGTM label has been added. Git tree hash: 9137b59d668ca5587d3f58a4c46f0b0f918f89e1
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mfilocha The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Proposal for the Polish translation of the 'Download Kubernetes' section.
PL translation of the 'Download Kubernetes' (download.md) section. Pushing to the main branch in the absence of the dev-pl localization branch.