Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the link of supposed example in topology-spread-constraints.md #43702

Merged
merged 2 commits into from
Jan 22, 2024
Merged

Add the link of supposed example in topology-spread-constraints.md #43702

merged 2 commits into from
Jan 22, 2024

Conversation

vaibhav2107
Copy link
Member

Ref: #39218

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 26, 2023
@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Oct 26, 2023
@k8s-ci-robot k8s-ci-robot added sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 26, 2023
@vaibhav2107 vaibhav2107 mentioned this pull request Oct 26, 2023
Closed
@vaibhav2107
Copy link
Member Author

Hi @kbhawkey @natalisucks
Could you please have a look

sftim
sftim reviewed Oct 27, 2023
View reviewed changes
content/en/docs/concepts/scheduling-eviction/topology-spread-constraints.md Outdated
Comment on lines 483 to 484
1. any Pods located on those bypassed nodes do not impact `maxSkew` calculation - [in the
above example](#example-conflicting-topologyspreadconstraints), suppose the node `node1` does not have a label "zone", then the 2 Pods will
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
1. any Pods located on those bypassed nodes do not impact `maxSkew` calculation - [in the
above example](#example-conflicting-topologyspreadconstraints), suppose the node `node1` does not have a label "zone", then the 2 Pods will
1. any Pods located on those bypassed nodes do not impact `maxSkew` calculation - in the
above [example](#example-conflicting-topologyspreadconstraints), suppose the node `node1` does not have a label "zone", then the 2 Pods will

even better. The link is to an example, not to an in the above example.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sftim Thanks for the suggestion

@netlify Netlify
Copy link

netlify bot commented Nov 24, 2023

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit bbf3000
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/6560128f1b146b00081d5796
😎 Deploy Preview https://deploy-preview-43702--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@vaibhav2107
Copy link
Member Author

@sftim I have updated the PR, please take a look now

@sftim
Copy link
Contributor

sftim commented Dec 27, 2023

@sftim I have updated the PR, please take a look now

Actually, I'm happy for any contributor to review this PR.

@natalisucks
Copy link
Contributor

Thanks @vaibhav2107!
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 19, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: e24268dac55f954937537fe8d6e476312166c37a

divya-mohan0209
divya-mohan0209 reviewed Jan 22, 2024
View reviewed changes
Copy link
Contributor

@divya-mohan0209 divya-mohan0209 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: divya-mohan0209

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 22, 2024
@k8s-ci-robot k8s-ci-robot merged commit bd5a186 into kubernetes:main Jan 22, 2024
6 checks passed
@vaibhav2107
Copy link
Member Author

Thanks @divya-mohan0209

@vaibhav2107 vaibhav2107 mentioned this pull request Feb 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sftim sftim sftim left review comments

@divya-mohan0209 divya-mohan0209 divya-mohan0209 left review comments

@kbhawkey kbhawkey Awaiting requested review from kbhawkey

@natalisucks natalisucks Awaiting requested review from natalisucks

Assignees

@natalisucks natalisucks

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vaibhav2107 @sftim @natalisucks @k8s-ci-robot @divya-mohan0209