Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First-time tutorials import from k/examples #4353

Merged
merged 2 commits into from
Jul 21, 2017
Merged

First-time tutorials import from k/examples #4353

merged 2 commits into from
Jul 21, 2017

Conversation

ahmetb
Copy link
Member

@ahmetb ahmetb commented Jul 11, 2017

This imports the tutorials from kubernetes/examples repository for the first
time. It adds "DO NOT UPDATE" notices and updates some titles. These tutorials
will be maintained at k/examples repository.

Also fixing a bug in the update script (we were inserting the <!-- comments
before the metadata section on the top, causing articles to render incorrectly).


This change is Reviewable

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 11, 2017
This imports the tutorials from kubernetes/examples repository for the first
time. It adds "DO NOT UPDATE" notices and updates some titles. These tutorials
will be maintained at k/examples repository.

Also fixing a bug in the update script (we were inserting the `<!--` comments
before the metadata section on the top, causing articles to render incorrectly).

Signed-off-by: Ahmet Alp Balkan <ahmetb@google.com>
@ahmetb
Copy link
Member Author

ahmetb commented Jul 12, 2017

/assign @chenopis ready to review.

@pwittrock
Copy link
Member

/unassign

@ahmetb
Copy link
Member Author

ahmetb commented Jul 18, 2017

@chenopis PTAL.

@ahmetb
Copy link
Member Author

ahmetb commented Jul 21, 2017

@chenopis PTAL

Copy link
Contributor

@chenopis chenopis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@chenopis chenopis merged commit 8b687fc into kubernetes:master Jul 21, 2017
chenopis added a commit that referenced this pull request Jul 24, 2017
…hub.io into netlify-move

* 'master' of https://github.com/kubernetes/kubernetes.github.io:
  fix some writen mistake
  First-time tutorials import from k/examples (#4353)
  Fix An error 404 and fix a wrong hyperlink
  Updates to box.html and golfnow.html (#4277)
  Fixes issue #4389
jesscodez pushed a commit that referenced this pull request Sep 22, 2017
This imports the tutorials from kubernetes/examples repository for the first
time. It adds "DO NOT UPDATE" notices and updates some titles. These tutorials
will be maintained at k/examples repository.

Also fixing a bug in the update script (we were inserting the `<!--` comments
before the metadata section on the top, causing articles to render incorrectly).

Signed-off-by: Ahmet Alp Balkan <ahmetb@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants