-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
First-time tutorials import from k/examples #4353
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This imports the tutorials from kubernetes/examples repository for the first time. It adds "DO NOT UPDATE" notices and updates some titles. These tutorials will be maintained at k/examples repository. Also fixing a bug in the update script (we were inserting the `<!--` comments before the metadata section on the top, causing articles to render incorrectly). Signed-off-by: Ahmet Alp Balkan <ahmetb@google.com>
/assign @chenopis ready to review. |
/unassign |
@chenopis PTAL. |
@chenopis PTAL |
chenopis
approved these changes
Jul 21, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
chenopis
added a commit
that referenced
this pull request
Jul 24, 2017
…hub.io into netlify-move * 'master' of https://github.com/kubernetes/kubernetes.github.io: fix some writen mistake First-time tutorials import from k/examples (#4353) Fix An error 404 and fix a wrong hyperlink Updates to box.html and golfnow.html (#4277) Fixes issue #4389
jesscodez
pushed a commit
that referenced
this pull request
Sep 22, 2017
This imports the tutorials from kubernetes/examples repository for the first time. It adds "DO NOT UPDATE" notices and updates some titles. These tutorials will be maintained at k/examples repository. Also fixing a bug in the update script (we were inserting the `<!--` comments before the metadata section on the top, causing articles to render incorrectly). Signed-off-by: Ahmet Alp Balkan <ahmetb@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This imports the tutorials from kubernetes/examples repository for the first
time. It adds "DO NOT UPDATE" notices and updates some titles. These tutorials
will be maintained at k/examples repository.
Also fixing a bug in the update script (we were inserting the
<!--
commentsbefore the metadata section on the top, causing articles to render incorrectly).
This change is