Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: secret missing in docker-registry secret command in kubectl-comm… #43185

Merged
merged 1 commit into from
Oct 9, 2023

Conversation

MeenuyD
Copy link
Contributor

@MeenuyD MeenuyD commented Sep 24, 2023

Corrected the usage section for the 'kubectl create docker-registry' command to accurately reflect the command syntax.

Original:
$ kubectl create docker-registry NAME --docker-username=user --docker-password=password --docker-email=email [--docker-server=string] [--from-file=[key=]source] [--dry-run=server|client|none]

Corrected:
$ kubectl create secret docker-registry NAME --docker-username=user --docker-password=password --docker-email=email [--docker-server=string] [--from-file=[key=]source] [--dry-run=server|client|none]
#43180

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Sep 24, 2023
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 24, 2023
@netlify
Copy link

netlify bot commented Sep 24, 2023

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit da06ff0
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/6510553fba66f00008fffb79
😎 Deploy Preview https://deploy-preview-43185--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@dipesh-rawat dipesh-rawat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! The file (kubectl-commands.html) edited is generated automatically, not altered manually. For additional information, please refer to the following webpage: https://kubernetes.io/docs/contribute/generate-ref-docs/kubectl/

If this is an issue, we should fix either the generator code or the source the generator uses as its input. I'm not entirely familiar with the specifics of the generative logic. Perhaps @tengqm can provide feedback.

@dipesh-rawat
Copy link
Member

For review and feedback.
/cc @tengqm

@k8s-ci-robot k8s-ci-robot requested a review from tengqm September 24, 2023 18:13
@MeenuyD
Copy link
Contributor Author

MeenuyD commented Sep 24, 2023

Thank you for your contribution! The file (kubectl-commands.html) edited is generated automatically, not altered manually. For additional information, please refer to the following webpage: https://kubernetes.io/docs/contribute/generate-ref-docs/kubectl/

If this is an issue, we should fix either the generator code or the source the generator uses as its input. I'm not entirely familiar with the specifics of the generative logic. Perhaps @tengqm can provide feedback.

Thank you for the clarification! I appreciate the information about the generation process for the documentation.Thanks again for your guidance!

@Shubham82
Copy link
Contributor

@MeenuyD For more information please refer to the description of the following PR #42664

@tengqm
Copy link
Contributor

tengqm commented Oct 9, 2023

/lgtm
/approve
As a workaround.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 9, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 64c80f11a01417a93eab5f39874b44df81391c06

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 9, 2023
@k8s-ci-robot k8s-ci-robot merged commit 8ff62f8 into kubernetes:main Oct 9, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants