Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): missing "service" command name #43005

Merged

Conversation

CaioAugustoo
Copy link
Contributor

@CaioAugustoo CaioAugustoo commented Sep 11, 2023

kubectl create clusterip NAME &
kubectl create externalname NAME --external-name external.name [--dry-run=server|client|none]

This command is missing "service".

Correct command must be:

kubectl create service externalname NAME --external-name external.name [--dry-run=server|client|none] &
kubectl create service clusterip NAME [--tcp=<port>:<targetPort>] [--dry-run=server|client|none]

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Sep 11, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: CaioAugustoo / name: Caio Augusto (fb4b8c9)

@k8s-ci-robot
Copy link
Contributor

Welcome @CaioAugustoo!

It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/website has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Sep 11, 2023
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. sig/docs Categorizes an issue or PR as relevant to SIG Docs. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Sep 11, 2023
@netlify
Copy link

netlify bot commented Sep 11, 2023

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit fb4b8c9
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/64ff242bf19a96000858341d
😎 Deploy Preview https://deploy-preview-43005--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@CaioAugustoo
Copy link
Contributor Author

This PR is related with #43006

@k8s-ci-robot
Copy link
Contributor

@iagonc: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Shubham82
Copy link
Contributor

/sig network

@k8s-ci-robot k8s-ci-robot added the sig/network Categorizes an issue or PR as relevant to SIG Network. label Sep 12, 2023
@Shubham82
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 12, 2023
@mengjiao-liu
Copy link
Member

refer to #43006 (comment)

/cc @tengqm

@k8s-ci-robot k8s-ci-robot requested a review from tengqm September 12, 2023 09:24
@Shubham82
Copy link
Contributor

refer to #43006 (comment)

/cc @tengqm

as per above comment, removing lgtm.

/remove-lgtm

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 14, 2023
@tengqm
Copy link
Contributor

tengqm commented Sep 26, 2023

We can merge this as is.
We are still not settled on a new way to generate the reference docs.
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 26, 2023
@Shubham82
Copy link
Contributor

We can merge this as is. We are still not settled on a new way to generate the reference docs. /approve

Thanks @tengqm for this information.

@Shubham82
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 26, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 51fae6b3c27fa5fa8330d7e9ed6c34f70b16b33f

@k8s-ci-robot k8s-ci-robot merged commit f52dec4 into kubernetes:main Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/network Categorizes an issue or PR as relevant to SIG Network. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants