Add an explanation of how the kubeadm kubelet dropin file works and a note about cAdvisor by luxas · Pull Request #4229 · kubernetes/website

luxas · 2017-06-29T11:11:24Z

/cc @roberthbailey @jbeda @chenopis @lukemarsden

This was discussed in kubernetes/release#356. I'm adding some context on how the dropin works and information about how the user might revert kubernetes/release#356 if they have to.

This change is

chenopis

Some minor grammar changes for consistency and markdown formatting issues.

chenopis · 2017-06-29T18:19:49Z


 `${ARCH}` can be one of: `amd64`, `arm`, `arm64`, `ppc64le` or `s390x`.

+## Managing the kubeadm dropin file for the kubelet


change all occurrences of "dropin" to "drop-in"

chenopis · 2017-06-29T18:21:00Z

+```
+
+A breakdown of what/why:
+ - `--kubeconfig=/etc/kubernetes/kubelet.conf` point to the kubeconfig file that


"point" -> "points"

chenopis · 2017-06-29T18:21:32Z

+   started until `kubeadm init` is run.
+ - `--pod-manifest-path=/etc/kubernetes/manifests` specifies from where to read
+   Static Pod manifests used for spinning up the control plane
+ - `--allow-privileged=true` allow this kubelet to run privileged Pods


"allow" -> "allows"

chenopis · 2017-06-29T18:21:45Z

+ - `--pod-manifest-path=/etc/kubernetes/manifests` specifies from where to read
+   Static Pod manifests used for spinning up the control plane
+ - `--allow-privileged=true` allow this kubelet to run privileged Pods
+ - `--network-plugin=cni` use CNI networking


"use" -> "uses"

chenopis · 2017-06-29T18:22:29Z

+   Static Pod manifests used for spinning up the control plane
+ - `--allow-privileged=true` allow this kubelet to run privileged Pods
+ - `--network-plugin=cni` use CNI networking
+ - `--cni-conf-dir=/etc/cni/net.d` where to look for the


add "specifies": "--cni-conf-dir=/etc/cni/net.d specifies where to look..."

chenopis · 2017-06-29T18:25:16Z

+   `search` entries in Pods' `/etc/resolv.conf`
+ - `--client-ca-file=/etc/kubernetes/pki/ca.crt` authenticate requests to the Kubelet
+   API using this CA certificate.
+ - `--authorization-mode=Webhook` authorize requests to the Kubelet API by `POST`-ing


"authorize" -> "authorizes"

chenopis · 2017-06-29T18:27:19Z

+   API using this CA certificate.
+ - `--authorization-mode=Webhook` authorize requests to the Kubelet API by `POST`-ing
+   a `SubjectAccessReview` to the API Server
+ - `--cadvisor-port=0` disable that cAdvisor listens to `0.0.0.0:4194` by default.


suggested edit: "--cadvisor-port=0 disables cAdvisor from listening to 0.0.0.0:4194 by default."

chenopis · 2017-06-29T18:27:51Z

+   a `SubjectAccessReview` to the API Server
+ - `--cadvisor-port=0` disable that cAdvisor listens to `0.0.0.0:4194` by default.
+   cAdvisor will still be run inside of the kubelet and its API can be accessed at
+   `https://{node-ip}:10250/stats/`. If you want to enable that cAdvisor listens on


suggested edit: "If you want to enable cAdvisor to listen on a wide-open port, run:"

chenopis · 2017-06-29T18:31:22Z

+ExecStart=/usr/bin/kubelet $KUBELET_KUBECONFIG_ARGS $KUBELET_SYSTEM_PODS_ARGS $KUBELET_NETWORK_ARGS $KUBELET_DNS_ARGS $KUBELET_AUTHZ_ARGS $KUBELET_CADVISOR_ARGS $KUBELET_EXTRA_ARGS
+```
+
+A breakdown of what/why:


You should change these into an unordered (bulleted) list. Markdown is currently rendering them as a single paragraph, see preview: https://deploy-preview-4229--kubernetes-io-master-staging.netlify.com/docs/admin/kubeadm/

chenopis · 2017-06-29T18:32:51Z

+   cAdvisor will still be run inside of the kubelet and its API can be accessed at
+   `https://{node-ip}:10250/stats/`. If you want to enable that cAdvisor listens on
+   a wide-open port, run:
+   ```


Add a newline above this line so that the shell snippet is rendered in a separate block on its own line, see preview: https://deploy-preview-4229--kubernetes-io-master-staging.netlify.com/docs/admin/kubeadm/

chenopis · 2017-06-30T05:58:49Z

@luxas Can you rebase this onto master? Now that v1.7 is out, the release-v1.7 branch is closed. Thx

luxas · 2017-06-30T07:17:16Z

@chenopis Done!

chenopis

unordered list still not rendering correctly; might need a newline before it

chenopis · 2017-06-30T07:21:38Z

+```
+
+A breakdown of what/why:
+* `--kubeconfig=/etc/kubernetes/kubelet.conf` points to the kubeconfig file that


I think you need a newline before this line. It's currently not rendering the unordered list correctly. See the preview: https://deploy-preview-4229--kubernetes-io-master-staging.netlify.com/docs/admin/kubeadm/#managing-the-kubeadm-drop-in-file-for-the-kubelet

Argh. Let's try again.

… note about cAdvisor

chenopis · 2017-06-30T08:19:17Z

@luxas I'm going to merge this. Any additional changes can be done in a follow-up PR.

k8s-ci-robot requested review from chenopis, jbeda, lukemarsden and roberthbailey June 29, 2017 11:11

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 29, 2017

k8s-github-robot assigned jbeda and errordeveloper Jun 29, 2017

This was referenced Jun 29, 2017

Disable publicly available cAdvisor kubernetes/release#356

Merged

cAdvisor shouldn't be publicly exposed by default kubernetes/kubeadm#321

Closed

chenopis added this to the 1.7 milestone Jun 29, 2017

chenopis suggested changes Jun 29, 2017

View reviewed changes

chenopis added Docs Review: Open Issues labels Jun 29, 2017

chenopis changed the base branch from release-1.7 to master June 30, 2017 05:54

chenopis changed the base branch from master to release-1.7 June 30, 2017 05:56

chenopis changed the base branch from release-1.7 to master June 30, 2017 05:56

chenopis changed the base branch from master to release-1.7 June 30, 2017 05:57

luxas force-pushed the add_kubeadm_cadvisor_note branch 2 times, most recently from 1ec1f02 to b49eb31 Compare June 30, 2017 06:53

luxas changed the base branch from release-1.7 to master June 30, 2017 06:55

chenopis suggested changes Jun 30, 2017

View reviewed changes

Add an explanation of how the kubeadm kubelet dropin file works and a…

df25909

… note about cAdvisor

luxas force-pushed the add_kubeadm_cadvisor_note branch from b49eb31 to df25909 Compare June 30, 2017 07:34

chenopis approved these changes Jun 30, 2017

View reviewed changes

chenopis added Docs LGTM and removed Docs Review: Open Issues labels Jun 30, 2017

chenopis merged commit b9f0a5d into kubernetes:master Jun 30, 2017

chenopis self-assigned this Aug 30, 2017

chenopis removed the Needs Tech Review label Aug 30, 2017


		`${ARCH}` can be one of: `amd64`, `arm`, `arm64`, `ppc64le` or `s390x`.

		## Managing the kubeadm dropin file for the kubelet

Conversation

luxas commented Jun 29, 2017 • edited by k8s-reviewable Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

chenopis left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

chenopis commented Jun 30, 2017

Uh oh!

luxas commented Jun 30, 2017

Uh oh!

chenopis left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

chenopis commented Jun 30, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

luxas commented Jun 29, 2017 •

edited by k8s-reviewable

Loading