Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs update for Job's backoff limit per index (alpha in 1.28) #41921

Merged
merged 2 commits into from
Aug 4, 2023
Merged

Docs update for Job's backoff limit per index (alpha in 1.28) #41921

merged 2 commits into from
Aug 4, 2023

Conversation

mimowo
Copy link
Contributor

@mimowo mimowo commented Jul 7, 2023 •
edited
Loading

Docs update for Alpha JobBackoffLimitPerIndex in 1.28.
Tracking issue: kubernetes/enhancements#3850

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 7, 2023
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Jul 7, 2023
@netlify
Copy link

netlify bot commented Jul 7, 2023

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 3552780
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/64a7c1dd0e72320008d20ffe
😎 Deploy Preview https://deploy-preview-41921--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sftim
Copy link
Contributor

sftim commented Jul 7, 2023

/sig apps

@k8s-ci-robot k8s-ci-robot added the sig/apps Categorizes an issue or PR as relevant to SIG Apps. label Jul 7, 2023
@mimowo mimowo changed the base branch from main to dev-1.28 July 20, 2023 09:31
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 20, 2023
@mimowo mimowo force-pushed the backoff-limit-per-index branch from 3552780 to 5fbc10a Compare July 20, 2023 09:46
@netlify
Copy link

netlify bot commented Jul 20, 2023 •
edited
Loading

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit 9e66b18
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/64cbbf95fd5ff60007e0f609

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jul 20, 2023
@mimowo mimowo force-pushed the backoff-limit-per-index branch from 5fbc10a to cf1e58f Compare July 20, 2023 11:50
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 20, 2023
@mimowo mimowo marked this pull request as ready for review July 20, 2023 12:09
@mimowo mimowo force-pushed the backoff-limit-per-index branch from cf1e58f to 43adce9 Compare July 20, 2023 12:12
@jensentanlo jensentanlo mentioned this pull request Jul 20, 2023
Open
8 tasks
@mimowo mimowo force-pushed the backoff-limit-per-index branch from 43adce9 to a3c1429 Compare July 20, 2023 12:19
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 20, 2023
@mimowo mimowo changed the title [WIP] Docs update for Alpha JobBackoffLimitPerIndex [placeholder PR] Docs update for Alpha JobBackoffLimitPerIndex [placeholder PR] Jul 20, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 20, 2023
@mimowo mimowo force-pushed the backoff-limit-per-index branch 2 times, most recently from 496c280 to f89656e Compare July 27, 2023 13:37
@alculquicondor
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 27, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: ffcada1bcfcdc54259eb812bbfbfc5fd5d3ad296

cortespao
cortespao reviewed Jul 31, 2023
View reviewed changes
Copy link
Contributor

@cortespao cortespao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great content. I've just added some suggestions :)

content/en/docs/concepts/workloads/controllers/job.md Outdated Show resolved Hide resolved
content/en/docs/concepts/workloads/controllers/job.md Outdated Show resolved Hide resolved
content/en/docs/concepts/workloads/controllers/job.md Outdated Show resolved Hide resolved
content/en/docs/concepts/workloads/controllers/job.md Outdated Show resolved Hide resolved
content/en/docs/concepts/workloads/controllers/job.md Outdated Show resolved Hide resolved
content/en/docs/concepts/workloads/controllers/job.md Outdated Show resolved Hide resolved
content/en/docs/concepts/workloads/controllers/job.md Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 1, 2023
@mimowo mimowo force-pushed the backoff-limit-per-index branch 4 times, most recently from bbf1f76 to 897ad9f Compare August 2, 2023 09:30
@sftim
Copy link
Contributor

sftim commented Aug 2, 2023

@alculquicondor, would you be willing to re-review for technical accuracy? It's also OK to decline or to suggest a different reviewer.

alculquicondor
alculquicondor reviewed Aug 3, 2023
View reviewed changes
Copy link
Member

@alculquicondor alculquicondor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still LGTM from technical PoV

content/en/docs/concepts/workloads/controllers/job.md Outdated Show resolved Hide resolved
content/en/docs/concepts/workloads/controllers/job.md Outdated Show resolved Hide resolved
@sftim
Copy link
Contributor

sftim commented Aug 3, 2023

Even with the outstanding [slightly more that] nits, let's merge this.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 3, 2023
@mimowo
Copy link
Contributor Author

mimowo commented Aug 3, 2023

/hold
Let me apply the nits before we merge.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 3, 2023
@mimowo @sftim
@alculquicondor @cortespao
Job Backoff Limit per index review remarks
9e66b18 
Co-authored-by: Tim Bannister <tim@scalefactory.com>
Co-authored-by: Aldo Culquicondor <1299064+alculquicondor@users.noreply.github.com>
Co-authored-by: Paola Cortés <51036950+cortespao@users.noreply.github.com>
@mimowo mimowo force-pushed the backoff-limit-per-index branch from 897ad9f to 9e66b18 Compare August 3, 2023 14:54
@mimowo
Copy link
Contributor Author

mimowo commented Aug 3, 2023

/hold cancel
applied the @alculquicondor remarks.

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 3, 2023
@mimowo
Copy link
Contributor Author

mimowo commented Aug 3, 2023

@sftim please LGTM if it looks good to merge.

@shannonxtreme
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 4, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 9e4ef07667388ce6aaa84c3bf60dcd48ad121f13

@k8s-ci-robot k8s-ci-robot merged commit 2b361a4 into kubernetes:dev-1.28 Aug 4, 2023
Rishit-dagli pushed a commit to Rishit-dagli/website that referenced this pull request Aug 12, 2023
@k8s-ci-robot @Rishit-dagli
Merge pull request kubernetes#41921 from mimowo/backoff-limit-per-index
a8ab898 
Docs update for Job's backoff limit per index (alpha in 1.28)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cortespao cortespao cortespao left review comments

@sftim sftim sftim left review comments

@kannon92 kannon92 kannon92 left review comments

@alculquicondor alculquicondor alculquicondor left review comments

@mehabhalodiya mehabhalodiya Awaiting requested review from mehabhalodiya

@onlydole onlydole Awaiting requested review from onlydole

Assignees

@alculquicondor alculquicondor

@shannonxtreme shannonxtreme

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
1.28
Development

Successfully merging this pull request may close these issues.
8 participants
@mimowo @sftim @Atharva-Shinde @k8s-ci-robot @alculquicondor @shannonxtreme @kannon92 @cortespao