-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add blog for non-graceful node shutdown #41914
Conversation
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
content/en/blog/_posts/2023-08-15-non-graceful-node-shutdown-to-ga.md
Outdated
Show resolved
Hide resolved
content/en/blog/_posts/2023-08-15-non-graceful-node-shutdown-to-ga.md
Outdated
Show resolved
Hide resolved
content/en/blog/_posts/2023-08-15-non-graceful-node-shutdown-to-ga.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your PR. I wrote some comments.
content/en/blog/_posts/2023-08-15-non-graceful-node-shutdown-to-ga.md
Outdated
Show resolved
Hide resolved
content/en/blog/_posts/2023-08-15-non-graceful-node-shutdown-to-ga.md
Outdated
Show resolved
Hide resolved
content/en/blog/_posts/2023-08-15-non-graceful-node-shutdown-to-ga.md
Outdated
Show resolved
Hide resolved
content/en/blog/_posts/2023-08-15-non-graceful-node-shutdown-to-ga.md
Outdated
Show resolved
Hide resolved
Comments are addressed. Thanks. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tengqm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thank you for updating. Looks good to me. |
lgtm from feature documentation perspective. /gtm |
/lgtm |
LGTM label has been added. Git tree hash: a2908aa47f66b9f7ea44ed586d4dc04470baf5e2
|
@tengqm - this didn't actually have a date assigned (by release comms) and needs a fix. We'll do that in a follow up PR. |
Also see #42546 (which will publish the article). |
Placeholder blog PR for kubernetes/enhancements#2268