Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ja] Fix mismatch in Labels and Selectors concept page #40614

Merged
merged 1 commit into from
Apr 12, 2023
Merged

[ja] Fix mismatch in Labels and Selectors concept page #40614

merged 1 commit into from
Apr 12, 2023

Conversation

Arhell
Copy link
Member

@Arhell Arhell commented Apr 11, 2023

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 11, 2023
@k8s-ci-robot k8s-ci-robot requested review from kakts and t-inu April 11, 2023 21:46
@k8s-ci-robot k8s-ci-robot added language/ja Issues or PRs related to Japanese language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Apr 11, 2023
@netlify
Copy link

netlify bot commented Apr 11, 2023

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 9d1d924
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/6435d51b950c9700071243c3
😎 Deploy Preview https://deploy-preview-40614--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@atoato88
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 11, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 4f7398bc52e3ceb7354f9e3abd16c12217cb0ac5

dipesh-rawat
dipesh-rawat reviewed Apr 11, 2023
View reviewed changes
Copy link
Member

@dipesh-rawat dipesh-rawat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes made here in sync with merged lang/en PR #39205

/lgtm

@nasa9084
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nasa9084

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 12, 2023
@k8s-ci-robot k8s-ci-robot merged commit 1bb518d into kubernetes:main Apr 12, 2023
@Arhell Arhell deleted the ja-fix branch April 12, 2023 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dipesh-rawat dipesh-rawat dipesh-rawat left review comments

@kakts kakts Awaiting requested review from kakts

@t-inu t-inu Awaiting requested review from t-inu

Assignees

@atoato88 atoato88

@nasa9084 nasa9084

@dipesh-rawat dipesh-rawat

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/ja Issues or PRs related to Japanese language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Arhell @atoato88 @k8s-ci-robot @nasa9084 @dipesh-rawat