Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add blog post for KMSv2 beta #40194

Merged
merged 7 commits into from
May 3, 2023
Merged

Add blog post for KMSv2 beta #40194

merged 7 commits into from
May 3, 2023

Conversation

aramase
Copy link
Member

@aramase aramase commented Mar 21, 2023

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 21, 2023
@k8s-ci-robot k8s-ci-robot added area/blog Issues or PRs related to the Kubernetes Blog subproject language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 21, 2023
@harshitasao
Copy link
Contributor

harshitasao commented Mar 22, 2023 •
edited
Loading

Hello, Comms Lead for the 1.27 release here. This feature blog is tracked for release, the deadline for submitting the draft is on 4th of April- the sooner the better since there's still editing to be done afterwards. Any doubt, the Comms team is here to help.
Thank you!

@harshitasao
Copy link
Contributor

Hello @aramase, we're doing a global reminder about submitting a draft for review for all opted-in feature blogs. If it's at all possible, it is very helpful for the release team to have drafts submitted for review before the hard deadline date, to better plan the release dates and avoid missing out. Thank you!

@aramase aramase force-pushed the aramase/d/kmsv2_beta_blog branch from 166fc9c to 81dc594 Compare March 31, 2023 22:35
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 31, 2023
@netlify
Copy link

netlify bot commented Mar 31, 2023 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 81b5487
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/64529ad9b522b50008556c2a
😎 Deploy Preview https://deploy-preview-40194--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@aramase
Add blog post for KMSv2 beta
164f7d0 
Signed-off-by: Anish Ramasekar <anish.ramasekar@gmail.com>
@aramase aramase force-pushed the aramase/d/kmsv2_beta_blog branch from 81dc594 to 164f7d0 Compare April 1, 2023 00:34
@aramase
Copy link
Member Author

aramase commented Apr 3, 2023

/sig auth

@k8s-ci-robot k8s-ci-robot added the sig/auth Categorizes an issue or PR as relevant to SIG Auth. label Apr 3, 2023
@aramase aramase force-pushed the aramase/d/kmsv2_beta_blog branch 2 times, most recently from 9dc2c6d to 346d760 Compare April 3, 2023 23:06
@aramase
add svg and reference in blog
0d84f89 
Signed-off-by: Anish Ramasekar <anish.ramasekar@gmail.com>
@aramase aramase force-pushed the aramase/d/kmsv2_beta_blog branch from 346d760 to 0d84f89 Compare April 3, 2023 23:23
@aramase
add performance improvements
42b0fc0 
Signed-off-by: Anish Ramasekar <anish.ramasekar@gmail.com>
@aramase aramase changed the title [WIP] Add blog post for KMSv2 beta Add blog post for KMSv2 beta Apr 4, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 4, 2023
enj
enj reviewed Apr 4, 2023
View reviewed changes
Copy link
Member

@enj enj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments.

content/en/blog/_posts/2023-04-11-kmsv2-beta.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2023-04-11-kmsv2-beta.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2023-04-11-kmsv2-beta.md Outdated Show resolved Hide resolved
@aramase
wrap long lines
6fc1a17 
Signed-off-by: Anish Ramasekar <anish.ramasekar@gmail.com>
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 12, 2023
@k8s-ci-robot k8s-ci-robot requested a review from sftim April 12, 2023 20:27
@tengqm
Copy link
Contributor

tengqm commented Apr 13, 2023

/label tide/merge-method-squash
/lgtm

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Apr 13, 2023
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 13, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: a7dc26141e56c75abb8e0becc2653dba48f0f1c9

@aramase
Copy link
Member Author

aramase commented Apr 14, 2023

@sftim If no further changes are required, could you /approve when you get a chance?

@harshitasao harshitasao mentioned this pull request Apr 24, 2023
Closed
@aramase
Copy link
Member Author

aramase commented May 1, 2023 •
edited
Loading

@harshitasao @sftim The blog publish date is today 05-01-2023. Has this changed?

@sftim
Copy link
Contributor

sftim commented May 2, 2023

/hold

We'll need a new publication date. Blog team did not have capacity to review by planned publication date. Sorry about that.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 2, 2023
@nate-double-u nate-double-u mentioned this pull request May 2, 2023
Merged
@harshitasao
Copy link
Contributor

@aramase Here is the new publication date 16-05-2023 (May 16)

@aramase
change blog date to 2023-05-16
81b5487 
Signed-off-by: Anish Ramasekar <anish.ramasekar@gmail.com>
@aramase
Copy link
Member Author

aramase commented May 3, 2023 •
edited
Loading

@aramase Here is the new publication date 16-05-2023 (May 16)

@harshitasao @sftim I've changed the date to 2023-05-16 in the PR as per the comment. PTAL!

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 3, 2023
@k8s-ci-robot k8s-ci-robot requested a review from tengqm May 3, 2023 17:33
@nate-double-u
Copy link
Contributor

Thanks @aramase & @harshitasao for setting a new date, and everyone for the reviews!

Reapplying LGTM:
/lgtm

Removing hold:
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 3, 2023
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 3, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: b29e137807409da59486c5facef299cdee70dda1

@nate-double-u
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nate-double-u

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 3, 2023
@k8s-ci-robot k8s-ci-robot merged commit 6d5ee25 into kubernetes:main May 3, 2023
@aramase aramase deleted the aramase/d/kmsv2_beta_blog branch May 3, 2023 18:37
DonatoHorn pushed a commit to DonatoHorn/website that referenced this pull request Jun 25, 2023
@aramase @DonatoHorn
Add blog post for KMSv2 beta (kubernetes#40194)
736e456 
* Add blog post for KMSv2 beta

Signed-off-by: Anish Ramasekar <anish.ramasekar@gmail.com>

* add svg and reference in blog

Signed-off-by: Anish Ramasekar <anish.ramasekar@gmail.com>

* add performance improvements

Signed-off-by: Anish Ramasekar <anish.ramasekar@gmail.com>

* address review feedback

Signed-off-by: Anish Ramasekar <anish.ramasekar@gmail.com>

* use 2023-05-01 for date/path and address review feedback

Signed-off-by: Anish Ramasekar <anish.ramasekar@gmail.com>

* wrap long lines

Signed-off-by: Anish Ramasekar <anish.ramasekar@gmail.com>

* change blog date to 2023-05-16

Signed-off-by: Anish Ramasekar <anish.ramasekar@gmail.com>

---------

Signed-off-by: Anish Ramasekar <anish.ramasekar@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harshitasao harshitasao harshitasao left review comments

@sozercan sozercan sozercan left review comments

@nate-double-u nate-double-u Awaiting requested review from nate-double-u

@enj enj Awaiting requested review from enj

@ritazh ritazh Awaiting requested review from ritazh

@sftim sftim Awaiting requested review from sftim

@tengqm tengqm Awaiting requested review from tengqm

Assignees

@ritazh ritazh

@nate-double-u nate-double-u

@tengqm tengqm

@enj enj

@sftim sftim

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/blog Issues or PRs related to the Kubernetes Blog subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
SIG Auth
Archived in project
SIG Auth: KMS v2
Status: ✅ Done
SIG Docs Blog Project Board
Status: Published
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@aramase @harshitasao @enj @k8s-ci-robot @ritazh @sftim @tengqm @nate-double-u @sozercan