Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ja] Update page weights under 5 sections of concepts #39869

Merged
merged 1 commit into from
Mar 10, 2023
Merged

[ja] Update page weights under 5 sections of concepts #39869

merged 1 commit into from
Mar 10, 2023

Conversation

s-kawamura-w664
Copy link
Contributor

This PR updates the page weights under the 5 sections in concepts.
This pr will be the last for the update of page weights under the ja/docs/concepts.

  • content/ja/docs/concepts/extend-kubernetes
  • content/ja/docs/concepts/containers
  • content/ja/docs/concepts/architecture
  • content/ja/docs/concepts/cluster-administration
  • content/ja/docs/concepts/policy

This updates the page order.

Related: #37470 #37471 #37473 #37484 #23929

The files under policy were updated long ago in en.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 9, 2023
@k8s-ci-robot k8s-ci-robot requested a review from kakts March 9, 2023 07:11
@k8s-ci-robot k8s-ci-robot added the language/ja Issues or PRs related to Japanese language label Mar 9, 2023
@k8s-ci-robot k8s-ci-robot requested a review from ptux March 9, 2023 07:11
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Mar 9, 2023
Arhell
Arhell reviewed Mar 9, 2023
View reviewed changes
Copy link
Member

@Arhell Arhell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/assign @atoato88

@atoato88
Copy link
Contributor

atoato88 commented Mar 9, 2023

LGTM but building demo site on Netlify failed.
Could you create empty commit for kicking the rebuild on Netlify?

@netlify
Copy link

netlify bot commented Mar 10, 2023

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit c33ef3e
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/640a710b9be9620009518d93
😎 Deploy Preview https://deploy-preview-39869--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@atoato88
Copy link
Contributor

We got the success of build!
I'll validate the links.

@s-kawamura-w664
Copy link
Contributor Author

@atoato88
Netlify deploy succeeded.
It fails well recently.

@atoato88
Copy link
Contributor

/lgtm

Nice work!!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 10, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: c99d6c6bd0a0f87f0d2ef7aa8a2df6b96b8e1c43

@atoato88
Copy link
Contributor

atoato88 commented Mar 10, 2023 •
edited
Loading

/assign @nasa9084
Could you review this?

nasa9084
nasa9084 reviewed Mar 10, 2023
View reviewed changes
Copy link
Member

@nasa9084 nasa9084 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nasa9084

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 10, 2023
@k8s-ci-robot k8s-ci-robot merged commit fd3e8ba into kubernetes:main Mar 10, 2023
@s-kawamura-w664 s-kawamura-w664 deleted the update_weight_concepts branch March 12, 2023 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Arhell Arhell Arhell left review comments

@nasa9084 nasa9084 nasa9084 left review comments

@kakts kakts Awaiting requested review from kakts

@ptux ptux Awaiting requested review from ptux

Assignees

@atoato88 atoato88

@nasa9084 nasa9084

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/ja Issues or PRs related to Japanese language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@s-kawamura-w664 @atoato88 @k8s-ci-robot @nasa9084 @Arhell