Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ReadWriteOncePod feature to beta #39843

Merged
merged 1 commit into from
Mar 20, 2023
Merged

Update ReadWriteOncePod feature to beta #39843

merged 1 commit into from
Mar 20, 2023

Conversation

chrishenzie
Copy link
Member

/sig storage
/sig scheduling
/cc @msau42

@k8s-ci-robot k8s-ci-robot requested a review from msau42 March 7, 2023 19:03
@k8s-ci-robot k8s-ci-robot added sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 7, 2023
@netlify
Copy link

netlify bot commented Mar 7, 2023 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit fef6eae
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/6410a2e2d11b0900081d98e2
😎 Deploy Preview https://deploy-preview-39843--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@chrishenzie chrishenzie force-pushed the read-write-once-pod-docs branch from d6be5c7 to afc8263 Compare March 7, 2023 22:59
@reylejano
Copy link
Member

As this PR has changes with the 1.27 release, please change the base branch and target the dev-1.27 branch
/milestone 1.27
/cc @mickeyboxell

@k8s-ci-robot k8s-ci-robot added this to the 1.27 milestone Mar 8, 2023
@chrishenzie chrishenzie force-pushed the read-write-once-pod-docs branch from afc8263 to fef6eae Compare March 14, 2023 16:37
@chrishenzie chrishenzie changed the base branch from main to dev-1.27 March 14, 2023 16:38
@chrishenzie chrishenzie force-pushed the read-write-once-pod-docs branch from fef6eae to e600a75 Compare March 14, 2023 20:53
@msau42
Copy link
Member

msau42 commented Mar 14, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 14, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 9cb4f19476a2ed292a7eb02ddc2979bb015fd345

tengqm
tengqm reviewed Mar 14, 2023
View reviewed changes
content/en/docs/concepts/storage/persistent-volumes.md
@@ -637,7 +637,8 @@ The access modes are:
: the volume can be mounted as read-write by many nodes.

`ReadWriteOncePod`
: the volume can be mounted as read-write by a single Pod. Use ReadWriteOncePod
: {{< feature-state for_k8s_version="v1.27" state="beta" >}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this feature-state shortcode works properly under a definition...
The preview cannot be checked...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works -- the preview can be found at:
https://deploy-preview-39843--kubernetes-io-main-staging.netlify.app/docs/concepts/storage/persistent-volumes/

Screenshot 2023-03-14 at 1 48 50 PM

@tengqm
Copy link
Contributor

tengqm commented Mar 20, 2023

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 20, 2023
@k8s-ci-robot k8s-ci-robot merged commit f6a72d1 into kubernetes:dev-1.27 Mar 20, 2023
@chrishenzie chrishenzie deleted the read-write-once-pod-docs branch March 20, 2023 16:56
@chrishenzie chrishenzie mentioned this pull request Apr 5, 2023
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msau42 msau42 msau42 left review comments

@tengqm tengqm tengqm left review comments

@mickeyboxell mickeyboxell Awaiting requested review from mickeyboxell

Assignees

@msau42 msau42

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
1.27
Development

Successfully merging this pull request may close these issues.
5 participants
@chrishenzie @reylejano @msau42 @k8s-ci-robot @tengqm