Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update kubectl reference for v1.25 #36946

Merged
merged 1 commit into from
Oct 8, 2022
Merged

Conversation

tengqm
Copy link
Contributor

@tengqm tengqm commented Sep 21, 2022

No description provided.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 21, 2022
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Sep 21, 2022
@netlify
Copy link

netlify bot commented Sep 21, 2022

Pull request preview available for checking

Name Link
🔨 Latest commit ed0578b
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/632d0b4c7d136d00086f9d82
😎 Deploy Preview https://deploy-preview-36946--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@reylejano
Copy link
Member

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: reylejano

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 21, 2022
@Sea-n
Copy link
Member

Sea-n commented Sep 21, 2022

Is that intended to include the static/docs/reference/generated/kubectl/node_modules/font-awesome/fonts/ directory?

I think it's a mistake. If not, maybe it would be better to describe it briefly.

@sftim
Copy link
Contributor

sftim commented Sep 21, 2022

/retitle Update kubectl reference for v1.25

@k8s-ci-robot k8s-ci-robot changed the title Kubectl reference for v1.25 Update kubectl reference for v1.25 Sep 21, 2022
@sftim
Copy link
Contributor

sftim commented Sep 21, 2022

The comment in #36946 (comment) looks like good feedback.

LGTM otherwise.

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 22, 2022
@tengqm
Copy link
Contributor Author

tengqm commented Sep 22, 2022

It is a long history. Let me try removing font-awesome together.

@tengqm
Copy link
Contributor Author

tengqm commented Sep 22, 2022

Looks like the missing css doesn't hurt much. We can postpone the improvement to the conversion tool to future.

@windsonsea
Copy link
Member

Thanks.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 8, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 245d82bd223f7a51729b17e7f7b0ac52511783dc

@k8s-ci-robot k8s-ci-robot merged commit 018bbfd into kubernetes:main Oct 8, 2022
@tengqm tengqm deleted the kubectl-125 branch October 8, 2022 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants