-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update kubeadm pages to use registry.k8s.io #34163
update kubeadm pages to use registry.k8s.io #34163
Conversation
k8s.gcr.io is a deprecated in favor of registry.k8s.io. The kubeadm code in k/k was already changed to use the new domain name.
👷 Deploy Preview for kubernetes-io-vnext-staging processing.
|
/sig cluster-lifecycle |
/cc @pacoxu |
/lgtm Should we mention that registry.k8s.io is currently redirecting to k8s.gcr.io somewhere? Or a link to introduce the new/old registry may help users. |
LGTM label has been added. Git tree hash: 282f80f8eb7ec2eb10b69918865c99420783a4de
|
/milestone 1.25 |
We could. I think we can link to the blogpost that was discussed about it. Not sure if it's WIP already. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
@pacoxu I don't think registry.k8s.io redirects to k8s.gcr.io |
registry.k8s.io is currently just a redirect to k8s.gcr.io. it's in the design doc:
|
the k/k PR with action required does not have the mention of a redirect: so i think we can omit it from the k/website docs as well. eventually i'm hoping that sig-k8s-infra will write a blog post about it. |
/sig k8s-infra |
/assign @sftim for approval. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kbhawkey The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s.gcr.io is a deprecated in favor of registry.k8s.io.
The kubeadm code in k/k was already changed to use the
new domain name.
(this is targeting 1.25)
xref kubernetes/kubeadm#2671
xref kubernetes/k8s.io#1834