Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update kubeadm pages to use registry.k8s.io #34163

Conversation

neolit123
Copy link
Member

@neolit123 neolit123 commented Jun 7, 2022

k8s.gcr.io is a deprecated in favor of registry.k8s.io.
The kubeadm code in k/k was already changed to use the
new domain name.

(this is targeting 1.25)

xref kubernetes/kubeadm#2671
xref kubernetes/k8s.io#1834

k8s.gcr.io is a deprecated in favor of registry.k8s.io.
The kubeadm code in k/k was already changed to use the
new domain name.
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 7, 2022
@netlify
Copy link

netlify bot commented Jun 7, 2022

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit edb74f1
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/629f5a61d169240008901299

@neolit123
Copy link
Member Author

/sig cluster-lifecycle
/kind deprecation cleanup

@k8s-ci-robot k8s-ci-robot added sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. language/en Issues or PRs related to English language labels Jun 7, 2022
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Jun 7, 2022
@neolit123
Copy link
Member Author

/cc @pacoxu
PTAL

@k8s-ci-robot k8s-ci-robot requested a review from pacoxu June 7, 2022 14:03
@pacoxu
Copy link
Member

pacoxu commented Jun 8, 2022

/lgtm

Should we mention that registry.k8s.io is currently redirecting to k8s.gcr.io somewhere? Or a link to introduce the new/old registry may help users.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 8, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 282f80f8eb7ec2eb10b69918865c99420783a4de

@reylejano
Copy link
Member

/milestone 1.25
/cc @kcmartin

@k8s-ci-robot k8s-ci-robot added this to the 1.25 milestone Jun 8, 2022
@neolit123
Copy link
Member Author

Should we mention that registry.k8s.io is currently redirecting to k8s.gcr.io somewhere? Or a link to introduce the new/old registry may help users.

We could. I think we can link to the blogpost that was discussed about it. Not sure if it's WIP already.

Copy link
Member

@SataQiu SataQiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@reylejano
Copy link
Member

@pacoxu I don't think registry.k8s.io redirects to k8s.gcr.io
See this email to dev@kubernetes.io

@neolit123
Copy link
Member Author

registry.k8s.io is currently just a redirect to k8s.gcr.io.
eventually it will become the actual registry, at which point k8s.gcr.io will become the redirect to registry.k8s.io.

it's in the design doc:
https://docs.google.com/document/d/1yNQ7DaDE5LbDJf9ku82YtlKZK0tcg5Wpk9L72-x2S2k/edit#heading=h.x9snb54sjlu9

We should implement a redirect proxy server on a k8s.io subdomain. The server should initially redirect all requests to the existing k8s.gcr.io

@neolit123
Copy link
Member Author

the k/k PR with action required does not have the mention of a redirect:
kubernetes/kubernetes#109938

so i think we can omit it from the k/website docs as well.

eventually i'm hoping that sig-k8s-infra will write a blog post about it.
https://github.com/orgs/kubernetes/projects/77/views/2

@reylejano
Copy link
Member

/sig k8s-infra
Discussed in the June 2022 monthly Kubernetes community meeting
/lgtm

@k8s-ci-robot k8s-ci-robot added the sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. label Jun 17, 2022
@RA489
Copy link

RA489 commented Jun 22, 2022

/assign @sftim for approval.

@kbhawkey
Copy link
Contributor

kbhawkey commented Jul 9, 2022

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kbhawkey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 9, 2022
@k8s-ci-robot k8s-ci-robot merged commit c61bd66 into kubernetes:dev-1.25 Jul 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants