Remove inconsistent use of addons #3327
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://github.com/kubernetes/kubernetes/wiki/CLA-FAQ to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
k8s-ci-robot
added
the
cncf-cla: no
bradtopol
force-pushed
the
addonsdoc
branch
2 times, most recently
from
592d458 to
2d761f8
Compare
This is the only place in all of the documentation where addon(s) is used instead of addons. Even though with brackets it can be read as one or more addons, it looks strange and inconsistent with the rest of the documentation. Signed-off-by: Brad Topol <btopol@us.ibm.com>
|
I signed it! |
|
ping to retrigger bot - maybe |
k8s-ci-robot
added
cncf-cla: yes
chenopis
added a commit
that referenced
this pull request
Apr 13, 2017
…hub.io into migration-concepts-container-lifecycle-hooks * 'master' of https://github.com/kubernetes/kubernetes.github.io: (47 commits) Remove inconsistent use of addons (#3327) Fix broken link Fix broken links fix link Fix outdated links on kubeadm.md (#3341) Fix broken links Fix broken link:admission-controllers Update /docs/samples to v1.6 `failure-domain` is no longer used in command line arg. comment TODO in service account page Fix path. (#3364) Move Support topics. (#3363) Move FAQs. (#3362) tools: list minikube as a Native Tool Added solution Madcore.Ai (#3336) Fix broken link (#3343) docs/admin: add docs on impersonation headers Remove file from TOC. (#3361) Deprecation phase 2: debugging-pods-and-rep ... (#3337) Fix broken link (#3335) ...
gyliu513
pushed a commit
to gyliu513/kubernetes.github.io
that referenced
this pull request
Apr 26, 2017
This is the only place in all of the documentation where addon(s) is used instead of addons. Even though with brackets it can be read as one or more addons, it looks strange and inconsistent with the rest of the documentation. Signed-off-by: Brad Topol <btopol@us.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the only place in all of the documentation where addon(s) is used
instead of addons. Even though with brackets it can be read as one or more
addons, it looks strange and inconsistent with the rest of the documentation.
This change is