-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document the new MinDomainsInPodTopologySpread feature gate #32340
Document the new MinDomainsInPodTopologySpread feature gate #32340
Conversation
👷 Deploy Preview for kubernetes-io-vnext-staging processing.
|
enhancement ref: kubernetes/enhancements/issues/3022 |
/assign @PI-Victor |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for opening the PR instead of me 👍
- **whenUnsatisfiable** indicates how to deal with a Pod if it doesn't satisfy the spread constraint: | ||
- `DoNotSchedule` (default) tells the scheduler not to schedule it. | ||
- `ScheduleAnyway` tells the scheduler to still schedule it while prioritizing nodes that minimize the skew. | ||
|
||
- **labelSelector** is used to find matching Pods. Pods that match this label selector are counted to determine the number of Pods in their corresponding topology domain. See [Label Selectors](/docs/concepts/overview/working-with-objects/labels/#label-selectors) for more details. | ||
|
||
When a Pod defines more than one `topologySpreadConstraint`, those constraints are ANDed: The kube-scheduler looks for a node for the incoming Pod that satisfies all the constraints. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add the example to describe minDomains?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd prefer adding the example as a mermaid diagram in a separate PR.
content/en/docs/concepts/workloads/pods/pod-topology-spread-constraints.md
Outdated
Show resolved
Hide resolved
content/en/docs/concepts/workloads/pods/pod-topology-spread-constraints.md
Outdated
Show resolved
Hide resolved
content/en/docs/concepts/workloads/pods/pod-topology-spread-constraints.md
Show resolved
Hide resolved
content/en/docs/concepts/workloads/pods/pod-topology-spread-constraints.md
Outdated
Show resolved
Hide resolved
7cd5d4d
to
e64cce3
Compare
Code PR merged in kubernetes/kubernetes#107674 |
LGTM label has been added. Git tree hash: 7eeccfc070341850400e274b10535b7f615b23e3
|
/cc @nate-double-u |
/sig scheduling |
/lgtm |
e64cce3
to
806994a
Compare
806994a
to
e4a473c
Compare
@PI-Victor, the LGTM got dropped after the last commit. Re-add and I'd be happy to approve. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
LGTM label has been added. Git tree hash: d5d1f25ab44b4143ca0a19a1c037d4b76d319c9d
|
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nate-double-u The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
xref: kubernetes/kubernetes#107674