Skip to content

Conversation

nate-double-u
Copy link
Contributor

Week 3 update to bring main into dev-1.24 branch.

renan and others added 30 commits November 2, 2021 14:03
The implementation defines the default value for MaxSurge being 0, as to
preserve the current behavior of rolling updates in DaemonSets.

This change is just a copy-paste of the docblock defined in the types.go
file.

See:
- https://github.com/kubernetes/kubernetes/blob/10a3cc815bea73f78f7126cab5df95233da96e1b/pkg/apis/apps/types.go
- https://github.com/kubernetes/kubernetes/blob/10a3cc815bea73f78f7126cab5df95233da96e1b/pkg/apis/apps/v1/defaults.go#L87-L91
As it's easy to misread this as curly brackets for users familiar with
shell interpolation.
Mention that the support via Dockershim is deprecated.

Co-Authored-By: Rey Lejano <rlejano@gmail.com>
This change updates how we run Hugo AND changes the logic for checking
whether a page should be indexable (copied with a backport from upstream
Docsy).
This allows CSS, JavaScript etc to detect if the served website is the
live one.
The community page had the wrong rendering for the page footer.
Ensure that the footer is as wide as the viewport.
Co-authored-by: Tim Bannister <tim@scalefactory.com>
Signed-off-by: Josh Berkus <josh@agliodbs.com>
The feature gate string (CSIMigrationRBD) was not matching with the
implementation (csiMigrationRBD) and this commit make it in parity

Ref# kubernetes/kubernetes#107571

Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
Add instructions for enabling fish auto-completions for kubectl
mention the correct feature gate name for RBD CSI migration.
Fix default value for MaxSurge in RollingUpdates for DaemonSets beat feature
…e_site_indexable

Make only live website indexable
from DaemonSetUpdateSurge feature gate short description
…aemonset_update_surge

Link to DaemonSet update task from DaemonSetUpdateSurge feature gate short description
Note that subPathExpr uses round brackets.
it: Link and description mismatch
it: Link and description mismatch
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jan 24, 2022
@nate-double-u nate-double-u changed the base branch from main to dev-1.24 January 24, 2022 17:11
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Jan 24, 2022
@nate-double-u
Copy link
Contributor Author

/milestone 1.24

@k8s-ci-robot k8s-ci-robot added this to the 1.24 milestone Jan 24, 2022
@nate-double-u
Copy link
Contributor Author

Errors relate to the EasyCLA — Missing CLA Authorization.

/cc @JamesLaverack, FYI
/cc @jlbutler @sftim @reylejano

@JamesLaverack
Copy link
Member

Errors relate to the EasyCLA — Missing CLA Authorization.

/cc @JamesLaverack, FYI /cc @jlbutler @sftim @reylejano

EasyCLA seems happy enough? Am I misunderstanding?

@netlify
Copy link

netlify bot commented Jan 24, 2022

✔️ Deploy Preview for kubernetes-io-main-staging ready!

🔨 Explore the source changes: 6fb319b

🔍 Inspect the deploy log: https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/61eeddc7381c210007904d65

😎 Browse the preview: https://deploy-preview-31490--kubernetes-io-main-staging.netlify.app

@nate-double-u
Copy link
Contributor Author

Commit 15bc0c7 has an error X on it, relating to the EasyCLA. It's not an error we generally need to concern ourselves with as EasyCLA is a work in progress, but it is an error, so I bring it up so folks know why it's failing.

@nate-double-u
Copy link
Contributor Author

If there were other kinds of errors then we may need to take action to correct them.

@sftim
Copy link
Contributor

sftim commented Jan 24, 2022

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 24, 2022
@jlbutler
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 24, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 7beee5f57fcdf4f891dc0f90dc72c55c297db441

@k8s-ci-robot k8s-ci-robot merged commit 7654b8c into kubernetes:dev-1.24 Jan 24, 2022
@nate-double-u nate-double-u deleted the merged-main-dev-1.24 branch January 24, 2022 21:11
@nate-double-u
Copy link
Contributor Author

Thanks everyone!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.