Skip to content

[ja] Fix kubernetes-api.md #31278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 21, 2022
Merged

[ja] Fix kubernetes-api.md #31278

merged 2 commits into from
Feb 21, 2022

Conversation

eltociear
Copy link
Contributor

markdown format

@eltociear
Fix kubernetes-api.md
8b89bb8 
markdown format
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 11, 2022
@k8s-ci-robot
Copy link
Contributor

Welcome @eltociear!

It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/website has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 11, 2022
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Jan 11, 2022
@netlify
Copy link

netlify bot commented Jan 11, 2022 •
edited
Loading

✔️ Deploy Preview for kubernetes-io-main-staging ready!

🔨 Explore the source changes: aa11e3f

🔍 Inspect the deploy log: https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/61f68b0403b1980007626b2a

😎 Browse the preview: https://deploy-preview-31278--kubernetes-io-main-staging.netlify.app

riita10069
riita10069 reviewed Jan 29, 2022
View reviewed changes
content/ja/docs/concepts/overview/kubernetes-api.md Outdated


Kubernetesは、他の手段として主にクラスター間の連携用途向けのAPIに、Protocol buffersをベースにしたシリアライズフォーマットを実装しています。このフォーマットに関しては、[Kubernetes Protobuf serialization](https://github.com/kubernetes/community/blob/master/contributors/des ign-proposals/api-machinery/protobuf.md)デザイン提案を参照してください。また、各スキーマのInterface Definition Language（IDL）ファイルは、APIオブジェクトを定義しているGoパッケージ内に配置されています。
Kubernetesは、他の手段として主にクラスター間の連携用途向けのAPIに、Protocol buffersをベースにしたシリアライズフォーマットを実装しています。このフォーマットに関しては、[Kubernetes Protobuf serialization](https://github.com/kubernetes/community/blob/master/contributors/design-proposals/api-machinery/protobuf.md)デザイン提案を参照してください。また、各スキーマのInterface Definition Language（IDL）ファイルは、APIオブジェクトを定義しているGoパッケージ内に配置されています。
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I accessed this link and it seems to be archived.

https://github.com/kubernetes/design-proposals-archive/blob/main/api-machinery/protobuf.md
I think this one is better.

riita10069
riita10069 reviewed Jan 29, 2022
View reviewed changes
@eltociear @riita10069
Update content/ja/docs/concepts/overview/kubernetes-api.md
aa11e3f 
Co-authored-by: Ryota Yamada <42636694+riita10069@users.noreply.github.com>
@eltociear
Copy link
Contributor Author

@riita10069 THX!

@riita10069
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 30, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: da54e2736f528840d96b86e17e5b6eb76f81aabf

@riita10069
Copy link
Member

/assign @nasa9084

@reylejano
Copy link
Member

/retitle [ja] Fix kubernetes-api.md

@k8s-ci-robot k8s-ci-robot changed the title Fix kubernetes-api.md [ja] Fix kubernetes-api.md Feb 11, 2022
@nasa9084
Copy link
Member

Thank you for your contribution~
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: avinashupadhya99, nasa9084

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 21, 2022
@k8s-ci-robot k8s-ci-robot merged commit 7b5ff60 into kubernetes:main Feb 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@inductor inductor Awaiting requested review from inductor

@kakts kakts Awaiting requested review from kakts

2 more reviewers

@riita10069 riita10069 riita10069 left review comments

@avinashupadhya99 avinashupadhya99 avinashupadhya99 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@nasa9084 nasa9084

@riita10069 riita10069

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/ja Issues or PRs related to Japanese language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@eltociear @k8s-ci-robot @riita10069 @reylejano @nasa9084 @avinashupadhya99