Improvements to kubernetes-basics/expose-intro.html #3103
Conversation
Updates to the non-interactive tutorial on exposing apps via services
k8s-ci-robot
added
the
cncf-cla: yes
mkorejo
changed the title
|
The travis-ci build may need to be restarted. This was opened a few days ago in the middle of their DB issue. |
|
@mkorejo Might as well fix the merge conflict. That should kick off a new travis-ci build. If it happens again, I'll try to restart it via the travis-ci.org site. |
|
@chenopis not following. I can't mark the conflict resolved as a I don't have the access. The changes in the PR are basically an overhaul of the page so there will always be a conflict that has to be merged manually by a contributor, if I understand correctly. Am I doing this right or am I missing something? Thanks. |
|
@mkorejo TL;DR: You many not have write privileges to If you're using the git command line or a git client, you'll need to pull |
| </div> | ||
| <div class="col-md-4"> | ||
| <div class="content__box content__box_fill"> | ||
| <p><i>You can create a Service at the same time you create a Deployment by using `--expose` in kubectl.</i></p> |
There was a problem hiding this comment.
Since markdown won't work here, you might want to remove the back ticks and try <code></code>. Also, currently, "--expose" is being wrapped, so I recommend putting a newline before the double hyphen.
| <a class="btn btn-lg btn-success" href="/docs/tutorials/kubernetes-basics/expose-interactive/" role="button">Start Interactive Tutorial<span class="btn__next">›</span></a> | ||
| </div> | ||
| </div> | ||
| </main> | ||
| </div> |
There was a problem hiding this comment.
I think you have one too many tags. The netlify rendering looks wrong. https://deploy-preview-3103--kubernetes-io-master-staging.netlify.com/docs/tutorials/kubernetes-basics/expose-intro/
|
@jaredbhatti This ready to be merged now? |
|
@jaredbhatti @chenopis still looking for a tech review? thanks for shuffling this along. |
…hub.io into migration-concepts-container-lifecycle-hooks * 'master' of https://github.com/kubernetes/kubernetes.github.io: (374 commits) Move Guide topic: ConfigMap. (#3333) Move Guide topic: H Pod Autoscaling Walkthrough. (#3332) Deprecation phase 2: kubefed. (#3331) Deprecation phase 2: admin/index ... (#3330) Deprecation phase 2: config-best-practices ... (#3328) Deprecation phase 2: container-environment ... (#3326) Deprecation phase 2: jobs (#3323) Deprecation phase 2: managing-deployments ... (#3309) Deprecation phase 2: kubectl binary_release ... (#3308) Improvements to kubernetes-basics/expose-intro.html (#3103) test/examples_test.go: validate docs/user-guide/pod-security-policy/psp.yaml (#3100) Move cron jobs to keep glossary in alphabetical order. Fix API server args Remove /redirects.rb (#3305) Move Guide topic: kubelet Garbage Collection. (#3301) Move Guide topic: Salt. (#3306) Fix tilte. (#3304) WIP: Cleanup /docs/contribute/ migration (#3278) Move Guide topic: HA Master. (#3303) Move Guide topic: Addons. (#3302) ... # Conflicts: # docs/api-reference/apps/v1beta1/definitions.html # docs/api-reference/batch/v1/definitions.html # docs/concepts/containers/container-lifecycle-hooks.md
* Massive updates to expose-intro.html Updates to the non-interactive tutorial on exposing apps via services * more updates to expose-intro * fixed broken link * fixed some wording * removed extra space * sub backticks for code and newline * added small legend to fist svg * fixed svg scaling * removed extra div
I was looking at issue 2907 and I thought this was something I could help with. I'm interested in contributing to the docs as I can. I couldn't do anything with the interactive part as that content seems auto-generated by katacoda. I assume I have to login at their site and do edits there once given the right access. Happy to do that too. In the meantime, take a look at these changes to the static part and see them running here:
http://104.198.206.107:9080/docs/tutorials/kubernetes-basics/expose-intro/
This change is