Make cleanup easier. #293
Make cleanup easier. #293
Conversation
|
@vishh Mind rebasing and then I can LGTM |
|
@foxish @apelisse @pwittrock @Kashomon Example of a doc PR that could benefit from the bot. |
|
@bgrant0607 -- can you elaborate? What features of the bot do you think apply here? |
|
This didn't get attention until ... now? |
|
@apelisse @Kashomon Yes, look how long this PR just sat around with no activity -- from March until ~week ago, and a week since then. There is no assigned reviewer. There is no |
|
@luxas PTAL |
|
@vishh Please rebase this and I'll get it over the finish line. |
|
|
||
| You may use `docker kill $(docker ps -aq)`, note this removes _all_ containers running under Docker, so use with caution. | ||
| ```shell | ||
| docker rm -f kubelet |
There was a problem hiding this comment.
The kubelet docker image isn't named kubelet anymore
There was a problem hiding this comment.
The best way is probably to name the kubelet container k8s_$(random-3char-hash), and then it'll be catched by the line below
There was a problem hiding this comment.
I added the kubelet container name back. It is the most reliable way to identify kubelet.
|
Rebased and comments addressed. PTAL. |
|
LGTM |
Make cleanup easier. Signed-off-by: Vishnu Kannan <vishnuk@google.com>
|
Rebased again. |
|
@luxas @kelseyhightower PTAL |
Signed-off-by: Kevin Lingerfelt <kl@buoyant.io>
Update settings.yml for dev-ko branch protection
No description provided.