Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1.22 feature blog for alpha swap support #29060

Merged
merged 2 commits into from
Aug 9, 2021
Merged

1.22 feature blog for alpha swap support #29060

merged 2 commits into from
Aug 9, 2021

Conversation

ehashman
Copy link
Member

@ehashman ehashman commented Jul 21, 2021 •
edited
Loading

Follow-up to #29016

Feature blog post for "Node Alpha swap support" (kubernetes/enhancements#2400).

This is part of the Kubernetes 1.22 release Feature blogs

Tentative publish date is 25th 18th August 2021.

Edit: fwiw I'm OOO the week of Aug. 23 so you might wanna hit publish before the 20th or after the 2nd :)

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 21, 2021
@k8s-ci-robot k8s-ci-robot added area/blog Issues or PRs related to the Kubernetes Blog subproject language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Jul 21, 2021
@netlify
Copy link

netlify bot commented Jul 21, 2021 •
edited
Loading

✔️ Deploy Preview for kubernetes-io-main-staging ready!

🔨 Explore the source changes: 39e39c0

🔍 Inspect the deploy log: https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/61115d08f39f0b000778b8c7

😎 Browse the preview: https://deploy-preview-29060--kubernetes-io-main-staging.netlify.app

sftim
sftim previously requested changes Jul 21, 2021
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this article.

/hold
Publication date isn't yet decided.

All the feedback I've marked as “nits” is optional. The other stuff is more important to address.

content/en/blog/_posts/2021-07-19-alpha-swap-support.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2021-07-19-alpha-swap-support.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2021-07-19-alpha-swap-support.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2021-07-19-alpha-swap-support.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2021-07-19-alpha-swap-support.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2021-07-19-alpha-swap-support.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2021-07-19-alpha-swap-support.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2021-07-19-alpha-swap-support.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2021-07-19-alpha-swap-support.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2021-07-19-alpha-swap-support.md Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 21, 2021
@ehashman
Copy link
Member Author

Addressed comments, thanks @sftim !

saschagrunert
saschagrunert reviewed Jul 22, 2021
View reviewed changes
Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few nits, otherwise LGTM

content/en/blog/_posts/2021-07-19-alpha-swap-support.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2021-07-19-alpha-swap-support.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2021-07-19-alpha-swap-support.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2021-07-19-alpha-swap-support.md Outdated Show resolved Hide resolved
@sftim sftim dismissed their stale review July 26, 2021 13:28

Review was out of date

@rajula96reddy rajula96reddy mentioned this pull request Jul 26, 2021
Closed
1 task
@sftim
Copy link
Contributor

sftim commented Jul 28, 2021

Once the publication date is set to something post-release (2021-08-18 is the one we've picked), it's OK to unhold this.

@ehashman
Copy link
Member Author

Moved to 08/18, PTAL.

@chrisnegus
Copy link
Contributor

There are kubeadm procedures in the docs (for install and upgrade) that explicitly say that swap must be disabled. Would it be appropriate for us to add notes describing this alpha feature in those places for people who want to turn on swap?

@sftim
Copy link
Contributor

sftim commented Aug 2, 2021

There are kubeadm procedures in the docs (for install and upgrade) that explicitly say that swap must be disabled. Would it be appropriate for us to add notes describing this alpha feature in those places for people who want to turn on swap?

Maybe, but this blog article doesn't have to be where we cover that. Instead, I'd imagine separate PRs that signpost readers from the kubeadm pages where swap is mentioned, to a new task page about “Deploy a Linux node with swap enabled” or similar. We would definitely want those pages before this graduates to beta.

@ehashman
Copy link
Member Author

ehashman commented Aug 2, 2021

There are kubeadm procedures in the docs (for install and upgrade) that explicitly say that swap must be disabled. Would it be appropriate for us to add notes describing this alpha feature in those places for people who want to turn on swap?

Please tag me for technical doc reviews for enabling this on kubeadm, I have not tested it and I am not sure if it's possible at this time.

@ehashman
Copy link
Member Author

ehashman commented Aug 3, 2021

/hold cancel
as release date has been updated, please review

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 3, 2021
@sftim
Copy link
Contributor

sftim commented Aug 5, 2021

@kubernetes/sig-node-pr-reviews - how is this looking in terms of technical accuracy?

@k8s-ci-robot k8s-ci-robot added the sig/node Categorizes an issue or PR as relevant to SIG Node. label Aug 5, 2021
@sftim
Copy link
Contributor

sftim commented Aug 5, 2021

/retest

rphillips
rphillips reviewed Aug 6, 2021
View reviewed changes
content/en/blog/_posts/2021-08-18-alpha-swap-support.md Outdated
workloads. Cluster administrators and developers should benchmark their nodes
and applications before using swap in production scenarios, and [we need your
help](#how-do-i-get-involved) with that!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. It would be nice to add to 'Caveats' a blurb about IOPS throttling in cloud environments. This might be a common issue that is overlooked by some.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a paragraph.

rphillips
rphillips reviewed Aug 6, 2021
View reviewed changes
content/en/blog/_posts/2021-08-18-alpha-swap-support.md Outdated
the kubelet should be able to be configured such that:

- It can start with swap on.
- It will direct the CRI to allocate Kubernetes workloads zero swap memory by
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sentence reads a little weird. Maybe:

It will direct the Container Runtime Interface to allocate zero swap memory to Kubernetes workloads by default.

or similar.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@rphillips
Copy link
Member

This looks great! +1 to publish!

@rphillips
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 6, 2021
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: c541eab6b27c7e3c49ca3d9ebf80351e852c1305

@jlbutler
Copy link
Contributor

jlbutler commented Aug 9, 2021

This one is complete, reviewed and ready to publish. With an ok from @sftim and @ehashman, I support publishing this today.

@ehashman
Copy link
Member Author

ehashman commented Aug 9, 2021

@jlbutler do you want me to update the date again?

@sftim
Copy link
Contributor

sftim commented Aug 9, 2021

@ehashman I can use my admin powers to push that commit, but feel free to do that yourself.

@sftim
Copy link
Contributor

sftim commented Aug 9, 2021

(also, nice-to-have, update the date in the PR description too)

@sftim
Copy link
Contributor

sftim commented Aug 9, 2021

/assign

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 9, 2021
@sftim
Copy link
Contributor

sftim commented Aug 9, 2021

/lgtm
(folliowing #29060 (comment))
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 9, 2021
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 0c201ed77f92db97e408a45a11a817f589c41c85

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 9, 2021
@k8s-ci-robot k8s-ci-robot merged commit 3e4fc78 into kubernetes:main Aug 9, 2021
@ehashman
Copy link
Member Author

ehashman commented Aug 9, 2021

Thank you!

@ehashman ehashman deleted the swap-blog branch August 9, 2021 17:41
@pacoxu pacoxu mentioned this pull request Sep 14, 2023
Open
60 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sftim sftim sftim left review comments

@chrisnegus chrisnegus chrisnegus left review comments

@rajula96reddy rajula96reddy rajula96reddy left review comments

@saschagrunert saschagrunert saschagrunert left review comments

@rphillips rphillips rphillips left review comments

@kbarnard10 kbarnard10 Awaiting requested review from kbarnard10

@onlydole onlydole Awaiting requested review from onlydole

Assignees

@rphillips rphillips

@sftim sftim

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/blog Issues or PRs related to the Kubernetes Blog subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/node Categorizes an issue or PR as relevant to SIG Node. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@ehashman @sftim @chrisnegus @rphillips @k8s-ci-robot @jlbutler @saschagrunert @rajula96reddy