Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Link for "Operator White Paper". #28625

Merged
merged 4 commits into from
Jun 25, 2021
Merged

Add Link for "Operator White Paper". #28625

merged 4 commits into from
Jun 25, 2021

Conversation

Shubham82
Copy link
Contributor

Add Link for Operator White Paper in Operator pattern docs.

Fixes: #28621

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 25, 2021
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 25, 2021
@Shubham82 Shubham82 mentioned this pull request Jun 25, 2021
Closed
@Shubham82
Copy link
Contributor Author

Hi @daminisatya @kbarnard10
Could you please take a look.

@netlify
Copy link

netlify bot commented Jun 25, 2021

✔️ Deploy Preview for kubernetes-io-main-staging ready!

🔨 Explore the source changes: 6ad9c33

🔍 Inspect the deploy log: https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/60d5a9685bf4f800075cb685

😎 Browse the preview: https://deploy-preview-28625--kubernetes-io-main-staging.netlify.app

sftim
sftim reviewed Jun 25, 2021
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

content/en/docs/concepts/extend-kubernetes/operator.md Outdated
@@ -124,6 +124,7 @@ Operator.
## {{% heading "whatsnext" %}}


* Learn about [Operator White Paper](https://github.com/cncf/tag-app-delivery/blob/eece8f7307f2970f46f100f51932db106db46968/operator-wg/whitepaper/Operator-WhitePaper_v1-0.md)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Learn about [Operator White Paper](https://github.com/cncf/tag-app-delivery/blob/eece8f7307f2970f46f100f51932db106db46968/operator-wg/whitepaper/Operator-WhitePaper_v1-0.md)
* Read the {{< glossary_tooltip text="CNCF" term_id="cncf" >}] [Operator White Paper](https://github.com/cncf/tag-app-delivery/blob/eece8f7307f2970f46f100f51932db106db46968/operator-wg/whitepaper/Operator-WhitePaper_v1-0.md).

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 25, 2021
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 4c915bbe6e242bc8f418a7267b7512d63ec82ac6

@netlify
Copy link

netlify bot commented Jun 25, 2021 •
edited
Loading

✔️ Deploy Preview for kubernetes-io-main-staging ready!

🔨 Explore the source changes: 57d21c6

🔍 Inspect the deploy log: https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/60d5da17a9df5c0007c28276

😎 Browse the preview: https://deploy-preview-28625--kubernetes-io-main-staging.netlify.app

@sftim
Copy link
Contributor

sftim commented Jun 25, 2021

Preview

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 25, 2021
@Shubham82
Copy link
Contributor Author

hi @sftim
PTAL!

Thanks

sftim
sftim reviewed Jun 25, 2021
View reviewed changes
content/en/docs/concepts/extend-kubernetes/operator.md Outdated
@@ -124,6 +124,7 @@ Operator.
## {{% heading "whatsnext" %}}


* Read the {{< glossary_tooltip text="CNCF" term_id="cncf" >}] [Operator White Paper](https://github.com/cncf/tag-app-delivery/blob/eece8f7307f2970f46f100f51932db106db46968/operator-wg/whitepaper/Operator-WhitePaper_v1-0.md).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops

Suggested change
* Read the {{< glossary_tooltip text="CNCF" term_id="cncf" >}] [Operator White Paper](https://github.com/cncf/tag-app-delivery/blob/eece8f7307f2970f46f100f51932db106db46968/operator-wg/whitepaper/Operator-WhitePaper_v1-0.md).
* Read the {{< glossary_tooltip text="CNCF" term_id="cncf" >}} [Operator White Paper](https://github.com/cncf/tag-app-delivery/blob/eece8f7307f2970f46f100f51932db106db46968/operator-wg/whitepaper/Operator-WhitePaper_v1-0.md).

@Shubham82
Copy link
Contributor Author

@sftim PTAL

sftim
sftim reviewed Jun 25, 2021
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 0147a1e856cf4e6eddc7c5a7b0846de4dcad3935

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 25, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 25, 2021
@k8s-ci-robot k8s-ci-robot merged commit 8b789a7 into kubernetes:main Jun 25, 2021
@npu21 npu21 mentioned this pull request Jun 29, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sftim sftim sftim left review comments

@daminisatya daminisatya Awaiting requested review from daminisatya

@kbarnard10 kbarnard10 Awaiting requested review from kbarnard10

Assignees

@sftim sftim

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add link from “Operator pattern” to CNCF operator white paper
3 participants
@Shubham82 @k8s-ci-robot @sftim