Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix navbar extra title line #28624

Merged
merged 1 commit into from
Jun 25, 2021
Merged

Fix navbar extra title line #28624

merged 1 commit into from
Jun 25, 2021

Conversation

tengqm
Copy link
Contributor

@tengqm tengqm commented Jun 25, 2021

This PR removes the "root" element from the navigation tree.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 25, 2021
@k8s-ci-robot k8s-ci-robot added sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 25, 2021
@tengqm
Copy link
Contributor Author

tengqm commented Jun 25, 2021

image

@netlify
Copy link

netlify bot commented Jun 25, 2021

✔️ Deploy Preview for kubernetes-io-main-staging ready!

🔨 Explore the source changes: 7b22f1a

🔍 Inspect the deploy log: https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/60d5a1e2aed35200089dc45c

😎 Browse the preview: https://deploy-preview-28624--kubernetes-io-main-staging.netlify.app

@sftim
Copy link
Contributor

sftim commented Jun 25, 2021

/area web-development
/approve

@k8s-ci-robot k8s-ci-robot added the area/web-development Issues or PRs related to the kubernetes.io's infrastructure, design, or build processes label Jun 25, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 25, 2021
Arhell
Arhell reviewed Jun 25, 2021
View reviewed changes
Copy link
Member

@Arhell Arhell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 25, 2021
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 3e7e9a2b26a9674604492b313ca24c0b77d4016d

@k8s-ci-robot k8s-ci-robot merged commit 487cdfa into kubernetes:main Jun 25, 2021
@tengqm tengqm deleted the fix-nav-root-line branch June 25, 2021 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Arhell Arhell Arhell left review comments

@celestehorgan celestehorgan Awaiting requested review from celestehorgan

@kbhawkey kbhawkey Awaiting requested review from kbhawkey

Assignees

@Arhell Arhell

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/web-development Issues or PRs related to the kubernetes.io's infrastructure, design, or build processes cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tengqm @sftim @k8s-ci-robot @Arhell