Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explain build image versioning for local preview container image #28484

Conversation

sftim
Copy link
Contributor

@sftim sftim commented Jun 18, 2021

Add a comment to help folks know that it's OK to bump the build image version as needed.

This build image is what we used for making the Hugo container image that contributors can then use for local site previews
(Netlify doesn't use that image for building the live site).

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 18, 2021
@sftim sftim requested a review from ameukam June 18, 2021 09:18
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Jun 18, 2021
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 18, 2021
@ameukam
Copy link
Member

ameukam commented Jun 18, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 18, 2021
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: f2e873c76acb51ef3831d2d039d5dacdcc6e491b

@netlify
Copy link

netlify bot commented Jun 18, 2021

✔️ Deploy Preview for kubernetes-io-master-staging ready!

🔨 Explore the source changes: 588d7ef

🔍 Inspect the deploy log: https://app.netlify.com/sites/kubernetes-io-master-staging/deploys/60cc64ebc6dfe30007147b7e

😎 Browse the preview: https://deploy-preview-28484--kubernetes-io-master-staging.netlify.app

@kbhawkey
Copy link
Contributor

Thanks @sftim .
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kbhawkey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 27, 2021
@k8s-ci-robot k8s-ci-robot merged commit 91afafd into kubernetes:main Jun 27, 2021
@sftim sftim deleted the 20210618_add_comment_about_cloudbuild_source_image_tag branch December 8, 2021 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants