Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ReadWriteOncePod access mode alpha docs #28114

Merged
merged 1 commit into from
Jul 27, 2021
Merged

ReadWriteOncePod access mode alpha docs #28114

merged 1 commit into from
Jul 27, 2021

Conversation

chrishenzie
Copy link
Member

@chrishenzie chrishenzie commented May 25, 2021 •
edited
Loading

Extends the PersistentVolume documentation to include the ReadWriteOncePod alpha access mode

For context, this access mode is only supported by CSI drivers because we are moving away from using in-tree drivers.

@k8s-ci-robot k8s-ci-robot added this to the 1.22 milestone May 25, 2021
@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 25, 2021
@k8sio-netlify-preview-bot
Copy link
Collaborator

k8sio-netlify-preview-bot commented May 25, 2021 •
edited by netlify bot
Loading

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

🔨 Explore the source changes: 2113947

🔍 Inspect the deploy log: https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/610032a2ac326c000702bc83

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 25, 2021
@chrishenzie chrishenzie mentioned this pull request May 25, 2021
Closed
12 tasks
@PI-Victor
Copy link
Member

/assign
/sig storage

@k8s-ci-robot k8s-ci-robot added the sig/storage Categorizes an issue or PR as relevant to SIG Storage. label May 26, 2021
@chrishenzie chrishenzie force-pushed the read-write-once-pod-access-mode branch from b5089b9 to 8ef12db Compare July 1, 2021 18:19
@chrishenzie chrishenzie force-pushed the read-write-once-pod-access-mode branch from 8ef12db to 06f884a Compare July 15, 2021 00:36
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 15, 2021
@chrishenzie chrishenzie changed the title WIP: Placeholder for ReadWriteOncePod access mode docs ReadWriteOncePod access mode alpha docs Jul 15, 2021
@chrishenzie chrishenzie marked this pull request as ready for review July 15, 2021 00:37
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 15, 2021
msau42
msau42 reviewed Jul 20, 2021
View reviewed changes
Copy link
Member

@msau42 msau42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also update feature-gates.md

content/en/docs/concepts/storage/persistent-volumes.md Outdated Show resolved Hide resolved
content/en/docs/concepts/storage/persistent-volumes.md Show resolved Hide resolved
@chrishenzie chrishenzie force-pushed the read-write-once-pod-access-mode branch 2 times, most recently from 75f2a32 to 25085f8 Compare July 22, 2021 19:52
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 22, 2021
@chrishenzie chrishenzie force-pushed the read-write-once-pod-access-mode branch from 25085f8 to da5d24f Compare July 22, 2021 19:57
@chrishenzie
Copy link
Member Author

Looks like the feature gate was updated separately in the base branch

@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 22, 2021
@chrishenzie
Copy link
Member Author

@msau42 I've moved the access mode to a separate section so the feature-state is correctly formatted, PTAL, thank you!

msau42
msau42 reviewed Jul 26, 2021
View reviewed changes
Copy link
Member

@msau42 msau42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

content/en/docs/concepts/storage/persistent-volumes.md Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 26, 2021
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 330d4886f83bde55de537ac95c283aa4e19e93c4

@chrishenzie chrishenzie force-pushed the read-write-once-pod-access-mode branch from da5d24f to 66dfcee Compare July 26, 2021 17:51
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 26, 2021
@PI-Victor
Copy link
Member

hey folks, please rebase this PR whenever you get the chance so we can move forward!

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 26, 2021
@chrishenzie chrishenzie force-pushed the read-write-once-pod-access-mode branch from 66dfcee to d138dd8 Compare July 26, 2021 22:05
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 26, 2021
@chrishenzie chrishenzie force-pushed the read-write-once-pod-access-mode branch from d138dd8 to 2113947 Compare July 27, 2021 16:21
@PI-Victor
Copy link
Member

thanks!

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 329ae3b8feb9c400d357ffd920a633a050b96a44

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 27, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: PI-Victor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 27, 2021
@k8s-ci-robot k8s-ci-robot merged commit 6098470 into kubernetes:dev-1.22 Jul 27, 2021
@chrishenzie chrishenzie deleted the read-write-once-pod-access-mode branch July 27, 2021 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msau42 msau42 msau42 left review comments

@tengqm tengqm tengqm left review comments

Assignees

@PI-Victor PI-Victor

@msau42 msau42

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
1.22
Development

Successfully merging this pull request may close these issues.
6 participants
@chrishenzie @k8sio-netlify-preview-bot @PI-Victor @k8s-ci-robot @tengqm @msau42