Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translate tasks/job/ into Japanese #27647

Merged
merged 2 commits into from
Apr 25, 2021
Merged

Translate tasks/job/ into Japanese #27647

merged 2 commits into from
Apr 25, 2021

Conversation

shuuji3
Copy link
Contributor

@shuuji3 shuuji3 commented Apr 21, 2021 •
edited
Loading

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 21, 2021
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Apr 21, 2021
@shuuji3
Copy link
Contributor Author

shuuji3 commented Apr 21, 2021

/assign @inductor

@netlify
Copy link

netlify bot commented Apr 21, 2021

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 248e051

https://deploy-preview-27647--kubernetes-io-master-staging.netlify.app

@atoato88
Copy link
Contributor

The preview on netlify has certainly entry of Jobの実行 on the page, but the next page has not any links.
Is it OK? 🤔
Same page in en has list of pages related to Job.

@shuuji3
Copy link
Contributor Author

shuuji3 commented Apr 22, 2021 •
edited
Loading

Yes, this is an expected behavior... Actually, this is a bug in the Docsy template used by Kubernetes documentation (please check this issue for details: #19309). It has been reported a while ago but hasn't been fixed yet. Although I tried to work on this issue in the past, the template was very complex and could not fix. 😅

I'm going to translate child pages. After that, the translated page should appear on the list. (But other pages won't appear until finishing the translation or fixing the above issue.)

@shuuji3
Copy link
Contributor Author

shuuji3 commented Apr 22, 2021 •
edited
Loading

So if you want, it's OK that you hold this PR until I translate at least one child page to prevent user confusion.

@atoato88
Copy link
Contributor

/lgtm
It's OK if you know the behavior I said.

All files merged in same time is ideal, but it's too heavy work and large PR. 😅
It doesn't seem to be created at same time in other language(ko, zh).

IMHO, it's good to merge this PR as is, and merge other content/ja/docs/tasks/job/ files as other PR in relatively short time .

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 22, 2021
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 48479da46adbd55a78d8ce763f080a8fed2791d6

@shuuji3
Copy link
Contributor Author

shuuji3 commented Apr 24, 2021

By merging #27699, at least one link should be shown on the list.

@inductor
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: inductor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 25, 2021
@k8s-ci-robot k8s-ci-robot merged commit 2d68a92 into kubernetes:master Apr 25, 2021
@shuuji3 shuuji3 deleted the shuuji3/translate-tasks-job-into-27646 branch April 25, 2021 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@makocchi-git makocchi-git Awaiting requested review from makocchi-git

@nasa9084 nasa9084 Awaiting requested review from nasa9084

Assignees

@atoato88 atoato88

@inductor inductor

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/ja Issues or PRs related to Japanese language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Translate tasks/job/ into Japanese
4 participants
@shuuji3 @atoato88 @k8s-ci-robot @inductor