Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add content/es/docs/concepts/configuration/configmap.md content/es/docs/reference/glossary/configmap.md #22576

Merged
merged 4 commits into from
Jul 24, 2020
Merged

Add content/es/docs/concepts/configuration/configmap.md content/es/docs/reference/glossary/configmap.md #22576

merged 4 commits into from
Jul 24, 2020

Conversation

Anynou
Copy link
Contributor

@Anynou Anynou commented Jul 18, 2020

No description provided.

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. language/es Issues or PRs related to Spanish language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Jul 18, 2020
@netlify
Copy link

netlify bot commented Jul 18, 2020 •
edited
Loading

Deploy preview for kubernetes-io-master-staging ready!

Built with commit dd0bd88

https://deploy-preview-22576--kubernetes-io-master-staging.netlify.app

@fejta-bot
Copy link

Unknown CLA label state. Rechecking for CLA labels.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/check-cla

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jul 18, 2020
@raelga
Copy link
Member

raelga commented Jul 22, 2020

Muchas gracias @Anynou!

@raelga raelga self-assigned this Jul 22, 2020
@raelga
Copy link
Member

raelga commented Jul 22, 2020

/cc @emedina

raelga
raelga reviewed Jul 22, 2020
View reviewed changes
Copy link
Member

@raelga raelga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Te he dejado algunas propuestas, no cambia mucho el texto original. Mayormente añade tooltips, corrige algunos errores tipográficos y poco más.

content/es/docs/reference/glossary/configmap.md Outdated Show resolved Hide resolved
content/es/docs/concepts/configuration/configmap.md Outdated Show resolved Hide resolved
content/es/docs/concepts/configuration/configmap.md Outdated Show resolved Hide resolved
content/es/docs/concepts/configuration/configmap.md Outdated Show resolved Hide resolved
content/es/docs/concepts/configuration/configmap.md Outdated Show resolved Hide resolved
content/es/docs/concepts/configuration/configmap.md Outdated Show resolved Hide resolved
content/es/docs/concepts/configuration/configmap.md Outdated Show resolved Hide resolved
content/es/docs/concepts/configuration/configmap.md Outdated Show resolved Hide resolved
content/es/docs/concepts/configuration/configmap.md Outdated Show resolved Hide resolved
content/es/docs/concepts/configuration/configmap.md Outdated Show resolved Hide resolved
@Anynou
Copy link
Contributor Author

Anynou commented Jul 22, 2020

Te he dejado algunas propuestas, no cambia mucho el texto original. Mayormente añade tooltips, corrige algunos errores tipográficos y poco más.

lo reviso y lo subo de nuevo

@raelga
Copy link
Member

raelga commented Jul 22, 2020 •
edited
Loading

Te he dejado algunas propuestas, no cambia mucho el texto original. Mayormente añade tooltips, corrige algunos errores tipográficos y poco más.

lo reviso y lo subo de nuevo

Genial, si lo prefieres, puedes aceptar las que estés del acuerdo desde la propia interfaz web.

Screenshot 2020-07-22 at 14 17 31

@raelga raelga added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Jul 22, 2020
@Anynou @raelga
Apply suggestions from code review
3998db2 
Changes accepted

Co-authored-by: Rael Garcia <rael@rael.io>
@Anynou
Copy link
Contributor Author

Anynou commented Jul 22, 2020

Hola Rael,

He aceptado todos los cambios. Si lo quieres comprobar, cuando puedas.

Un saludo.

raelga
raelga reviewed Jul 22, 2020
View reviewed changes
Copy link
Member

@raelga raelga left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gracias @Anynou, he metido sin querer un error en el glosario al hacer la sugerencia, lo puedes revisar?

content/es/docs/concepts/configuration/configmap.md Outdated Show resolved Hide resolved
@Anynou @raelga
Apply suggestions from code review
608c6c0 
error solved

Co-authored-by: Rael Garcia <rael@rael.io>
@Anynou
Copy link
Contributor Author

Anynou commented Jul 22, 2020

Gracias @Anynou, he metido sin querer un error en el glosario al hacer la sugerencia, lo puedes revisar?

Hecho

@raelga
Copy link
Member

raelga commented Jul 23, 2020

Genial @Anynou, por mi parte pinta genial! A ver si conseguimos otro review y lo publicamos!

/cc @electrocucaracha

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 23, 2020
@Anynou
Copy link
Contributor Author

Anynou commented Jul 24, 2020

Genial @Anynou, por mi parte pinta genial! A ver si conseguimos otro review y lo publicamos!

/cc @electrocucaracha

/lgtm

Perfecto Rael, comienzo con otra. Gracias.

@raelga raelga mentioned this pull request Jul 24, 2020
Closed
@emedina
Copy link
Contributor

emedina commented Jul 24, 2020

/lgtm

@raelga
Copy link
Member

raelga commented Jul 24, 2020

Gracias @emedina por la revisión!

Y muchas gracias @Anynou por la contribución, publicado!

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: raelga

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 24, 2020
@k8s-ci-robot k8s-ci-robot merged commit 6eaacd5 into kubernetes:master Jul 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raelga raelga raelga left review comments

@alexbrand alexbrand Awaiting requested review from alexbrand

@emedina emedina Awaiting requested review from emedina

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

Assignees

@emedina emedina

@raelga raelga

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/es Issues or PRs related to Spanish language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Anynou @fejta-bot @raelga @emedina @k8s-ci-robot