Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add irvifa as lead as a preparation step for transition #22256

Conversation

irvifa
Copy link
Member

@irvifa irvifa commented Jul 1, 2020

As mentioned in previous meeting, there's various step needed to be taken care of as a preparation for the shadow role for chairs.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 1, 2020
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Jul 1, 2020
@irvifa
Copy link
Member Author

irvifa commented Jul 1, 2020

Related to kubernetes/org#1976

@netlify
Copy link

netlify bot commented Jul 1, 2020

Deploy preview for kubernetes-io-master-staging ready!

Built with commit ddeb994

https://deploy-preview-22256--kubernetes-io-master-staging.netlify.app

@sftim
Copy link
Contributor

sftim commented Jul 3, 2020

/lgtm

/hold
for chair approval

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 3, 2020
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 3, 2020
@sftim
Copy link
Contributor

sftim commented Aug 3, 2020

Did this change get approved?

@kbhawkey
Copy link
Contributor

Is this pending or ready to merge?
/cc @kbarnard10 @jimangel

@jimangel
Copy link
Member

jimangel commented Oct 5, 2020

/lgtm
/approve
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 5, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jimangel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 5, 2020
@k8s-ci-robot k8s-ci-robot merged commit fc7ae87 into kubernetes:master Oct 5, 2020
@irvifa irvifa deleted the add-irvi-as-lead-as-transitioning-preparations branch October 5, 2020 16:30
@sftim
Copy link
Contributor

sftim commented Oct 5, 2020

Congratulations @irvifa !

@irvifa
Copy link
Member Author

irvifa commented Oct 5, 2020

Thanks! @sftim

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants