Skip to content

Added generator for running pod new documentation #20158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Added generator for running pod new documentation #20158

wants to merge 2 commits into from

Conversation

jayeshmahajan
Copy link
Contributor

No description provided.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 7, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign jaredbhatti
You can assign the PR to them by writing /assign @jaredbhatti in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Apr 7, 2020
@netlify
Copy link

netlify bot commented Apr 7, 2020 •
edited
Loading

Deploy preview for kubernetes-io-master-staging ready!

Built with commit ba72c5c

https://deploy-preview-20158--kubernetes-io-master-staging.netlify.com

@jayeshmahajan
Copy link
Contributor Author

/assign @jaredbhatti

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 7, 2020
sftim
sftim suggested changes Apr 7, 2020
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's some different wording @jayeshmahajan that you can switch to if you like

Either way, could you squash this to 1 commit? (if that's a problem, reply and there are ways that we, as approvers, can work around that)

content/en/docs/reference/kubectl/cheatsheet.md
kubectl apply -f https://git.io/vPieo # create resource(s) from url
kubectl create deployment nginx --image=nginx # start a single instance of nginx
kubectl explain pods # get the documentation for pod manifests
kubectl run --generator=run-pod/v1 nginx --image=nginx # create nginx pod without creating deployment
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
kubectl run --generator=run-pod/v1 nginx --image=nginx # create nginx pod without creating deployment
kubectl run --generator=run-pod/v1 nginx --image=nginx # start a single instance of nginx, without creating deployment

?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, in Kubernetes v1.18 all generators are documented. I don't think it's a good idea to add this to the cheat sheet.

@sftim
Copy link
Contributor

sftim commented Apr 18, 2020

@jayeshmahajan generators are deprecated. Are you willing to close this PR?

@jimangel
Copy link
Member

Closing this PR due to lack of response. Feel free to reopen if desired!
/close

@k8s-ci-robot
Copy link
Contributor

@jimangel: Closed this PR.

In response to this:

Closing this PR due to lack of response. Feel free to reopen if desired!
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jayeshmahajan jayeshmahajan mentioned this pull request May 27, 2025
Closed
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sftim sftim sftim requested changes

@daminisatya daminisatya Awaiting requested review from daminisatya

@krousey krousey Awaiting requested review from krousey

Assignees

@jaredbhatti jaredbhatti

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jayeshmahajan @k8s-ci-robot @sftim @jimangel @jaredbhatti