Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update pull request template following v1.17 release #18051

Merged
merged 1 commit into from
Jan 8, 2020
Merged

Update pull request template following v1.17 release #18051

merged 1 commit into from
Jan 8, 2020

Conversation

sftim
Copy link
Contributor

@sftim sftim commented Dec 10, 2019 •
edited
Loading

This pull request is ready for the arrival of a dev-1.18 branch.

/cc @daminisatya
Fixes #18541

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Dec 10, 2019
@netlify
Copy link

netlify bot commented Dec 10, 2019

Deploy preview for kubernetes-io-master-staging ready!

Built with commit c082353

https://deploy-preview-18051--kubernetes-io-master-staging.netlify.com

@sftim
Copy link
Contributor Author

sftim commented Dec 27, 2019

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 27, 2019
@sftim
Copy link
Contributor Author

sftim commented Jan 8, 2020

/sig release

@k8s-ci-robot k8s-ci-robot added the sig/release Categorizes an issue or PR as relevant to SIG Release. label Jan 8, 2020
@zacharysarah
Copy link
Contributor

/cc @VineethReddy02

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 8, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zacharysarah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 8, 2020
@k8s-ci-robot k8s-ci-robot merged commit a6584ad into kubernetes:master Jan 8, 2020
@sftim sftim deleted the 20191210_v1.17_update_pull_request_template branch January 8, 2020 23:55
wawa0210 pushed a commit to wawa0210/website that referenced this pull request Mar 2, 2020
@sftim @wawa0210
Update pull request template following v1.17 release (kubernetes#18051)
f4a3364
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daminisatya daminisatya Awaiting requested review from daminisatya

@VineethReddy02 VineethReddy02 Awaiting requested review from VineethReddy02

Assignees

@zacharysarah zacharysarah

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/release Categorizes an issue or PR as relevant to SIG Release. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pull request template out of date
3 participants
@sftim @zacharysarah @k8s-ci-robot