Update Hugo version in netlify.toml to 0.59.1

[zacharysarah]

This PR fixes a bug introduced by a partial upgrade in #17894. This PR updates the version to 0.59.1 in netlify.toml as well as Makefile.

11:07:44 PM:     [FAILURE] The Hugo version set in the Makefile is 0.59.1 while the version in netlify.toml is 0.57.2
11:07:44 PM:     [FAILURE] Please update these versions so that they are same (consider the higher of the two versions as canonical).

/assign @jimangel

[netlify]

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 09890d1

https://deploy-preview-17976--kubernetes-io-master-staging.netlify.com

[jimangel]

/lgtm
/approve

[kbarnard10]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jimangel, kbarnard10

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [jimangel,kbarnard10]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[Colstuwjx]

Hi @zacharysarah ，

I'm sorry about did this partial upgrade, and I am wondering if the netlify did not update to the same version inside makefile, why the PR #17894 CI Job did NOT throws error, it checked passed...

How could we avoid the same things happening again?
Thanks.

[zacharysarah]

@Colstuwjx 👋

I am wondering if the netlify did not update to the same version inside makefile, why the PR #17894 CI Job did NOT throws error

I honestly don't know why; it seems intuitive that the staging build would have produced the same error.

How could we avoid the same things happening again?

To be honest, I've made this same mistake in a previous PR. Usually my answer is "better documentation", but part of that answer is making sure that docs are in the right place. In this case, I don't know where it would be. 🤷‍♂ Any thoughts?

[Colstuwjx]

Hi @zacharysarah ,

For the Q1, I think I found the root cause, I did a PR in my fork repo, it throws error when I submitted deploy request to netlify:

8:58:00 PM: Executing user command: make production-build
8:58:00 PM: scripts/hugo-version-check.sh 0.59.1
8:58:00 PM: 0.57.2
8:58:00 PM:     [FAILURE] The Hugo version set in the Makefile is 0.59.1 while the version in netlify.toml is 0.57.2
8:58:00 PM:     [FAILURE] Please update these versions so that they are same (consider the higher of the two versions as canonical).
8:58:00 PM: Makefile:49: recipe for target 'check-hugo-versions' failed
8:58:00 PM: make: *** [check-hugo-versions] Error 1

the detail result see here

and our repo PR check, for example, likes below:

4:08:03 AM: Executing user command: hugo --enableGitInfo --buildFuture -b $DEPLOY_PRIME_URL
4:08:03 AM: Building sites …

The user command is different, our repo is hugo --enableGitInfo --buildFuture -b $DEPLOY_PRIME_URL, and my fork is make production-build, that's why we didn't see the error on our PR check, the PR is out of master branch, and would never exec context.master build command.

For the Q2, I think the script scripts/hugo-version-check.sh already did the right stuff, we just need to fix the Q1, for my idea, like sth for moving the command run with context.deploy-preview to makefile, and just write make deploy-preview with the command alongside with the check-hugo-versions.

Thanks.

[jimangel]

we just need to fix the Q1, for my idea, like sth for moving the command run with context.deploy-preview to makefile, and just write make deploy-preview with the command alongside with the check-hugo-versions.

Valid suggestion, however, I think we should try to source our Hugo Env in one location vs. relying on a check script. This isn't the first time we've hit this snag.

[Colstuwjx]

Hi @jimangel

I have been proposed a PR for fixing this issue permanently, see #18020 .
Thanks.