Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new owner and reviewer for Vietnamese content #17653

Merged
merged 1 commit into from
Nov 20, 2019

Conversation

huynguyennovem
Copy link
Member

Add huynguyennovem as an owner and reviewer for Vietnamese content

Signed-off-by: Nguyen Quang Huy huynguyennovem@gmail.com

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Nov 19, 2019
@k8s-ci-robot k8s-ci-robot added the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Nov 19, 2019
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Nov 19, 2019
@truongnh1992 truongnh1992 requested review from ngtuna and removed request for sftim and Rajakavitha1 November 19, 2019 08:13
@netlify
Copy link

netlify bot commented Nov 19, 2019

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 30bcde2

https://deploy-preview-17653--kubernetes-io-master-staging.netlify.com

@huynguyennovem
Copy link
Member Author

/assign @truongnh1992

@netlify
Copy link

netlify bot commented Nov 19, 2019

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 412c6ab

https://deploy-preview-17653--kubernetes-io-master-staging.netlify.com

Add huynguyennovem as an owner and reviewer for Vietnamese content
@truongnh1992
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 19, 2019
@truongnh1992
Copy link
Member

Here is the application for @huynguyennovem kubernetes/org#1427

@truongnh1992
Copy link
Member

/verify-owners

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Nov 20, 2019
@truongnh1992
Copy link
Member

/approve
@huynguyennovem has already become a member of Kubernetes org. Hope you will contribute more and more to K8s.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: truongnh1992
To complete the pull request process, please assign jaredbhatti
You can assign the PR to them by writing /assign @jaredbhatti in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@truongnh1992 truongnh1992 merged commit d30a1f6 into kubernetes:master Nov 20, 2019
@huynguyennovem
Copy link
Member Author

/approve
@huynguyennovem has already become a member of Kubernetes org. Hope you will contribute more and more to K8s.

Thank you @truongnh1992

@zacharysarah
Copy link
Contributor

@truongnh1992 It looks like you may have manually merged this PR. Is that the case?

@truongnh1992
Copy link
Member

@zacharysarah Yes, I merged this PR manually. @huynguyennovem is my co-worker at Vietnam Kubernetes Community, and he want to contribute to K8s document Vietnamese localization.

@zacharysarah
Copy link
Contributor

@truongnh1992 Thanks for the clarification. Manual merges aren’t acceptable; write permissions are solely for creating long-running collaborative branches.

Please confirm that you understand manual merges aren’t allowed, and will refrain from manually merging PRs in the future.

@truongnh1992
Copy link
Member

truongnh1992 commented Nov 20, 2019

@truongnh1992 Thanks for the clarification. Manual merges aren’t acceptable; write permissions are solely for creating long-running collaborative branches.

Please confirm that you understand manual merges aren’t allowed, and will refrain from manually merging PRs in the future.

@zacharysarah Thank you for your explain. I got it.
I'm sorry for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants