-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new owner and reviewer for Vietnamese content #17653
Add new owner and reviewer for Vietnamese content #17653
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
30bcde2
to
b69157f
Compare
Deploy preview for kubernetes-io-master-staging ready! Built with commit 30bcde2 https://deploy-preview-17653--kubernetes-io-master-staging.netlify.com |
/assign @truongnh1992 |
Deploy preview for kubernetes-io-master-staging ready! Built with commit 412c6ab https://deploy-preview-17653--kubernetes-io-master-staging.netlify.com |
Add huynguyennovem as an owner and reviewer for Vietnamese content
b69157f
to
412c6ab
Compare
/lgtm |
Here is the application for @huynguyennovem kubernetes/org#1427 |
/verify-owners |
/approve |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: truongnh1992 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thank you @truongnh1992 |
@truongnh1992 It looks like you may have manually merged this PR. Is that the case? |
@zacharysarah Yes, I merged this PR manually. @huynguyennovem is my co-worker at Vietnam Kubernetes Community, and he want to contribute to K8s document Vietnamese localization. |
@truongnh1992 Thanks for the clarification. Manual merges aren’t acceptable; write permissions are solely for creating long-running collaborative branches. Please confirm that you understand manual merges aren’t allowed, and will refrain from manually merging PRs in the future. |
@zacharysarah Thank you for your explain. I got it. |
Add huynguyennovem as an owner and reviewer for Vietnamese content
Signed-off-by: Nguyen Quang Huy huynguyennovem@gmail.com