Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new case study stylesheet #17334

Merged
merged 3 commits into from
Nov 7, 2019
Merged

Add new case study stylesheet #17334

merged 3 commits into from
Nov 7, 2019

Conversation

alexcontini
Copy link
Contributor

We will be adding a bunch of new case studies with an updated design (a lot of it is just simplified). I created this new file, and for the new case studies we will add
this updated code at the top from now on:


case_study_styles: true
cid: caseStudies
css: /css/new_case_studies.css

So just replacing the old css file with this one. Let me know if that is not going to work the way I think it will, thank you!

cc @jkld11

We will be adding a bunch of new case studies with an updated design (a lot of it is just simplified). I created this new file, and for the new case studies we will add
this updated code at the top from now on:

---
case_study_styles: true
cid: caseStudies
css: /css/new_case_studies.css
---

So just replacing the old css file with this one. Let me know if that is not going to work the way I think it will, thank you!
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Oct 31, 2019
@alexcontini
Copy link
Contributor Author

/assign @bradtopol

@netlify
Copy link

netlify bot commented Oct 31, 2019

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 7b473eb

https://deploy-preview-17334--kubernetes-io-master-staging.netlify.com

@sftim
Copy link
Contributor

sftim commented Oct 31, 2019

A nit about names:
“new” is one of those names that dates badly. Or you sometimes end up with names like new_newest_case_studies.css.
After the switchover, will /css/new_case_studies.css change name to /css/case_studies.css?

If not, how about putting a date in place of “new”?

@alexcontini
Copy link
Contributor Author

@sftim thank you and sounds like a good idea. I appreciate the help. Definitely makes sense why that would get confusing, so I have renamed it to case_studies_20191031.css (date at the end)

Let me know if that doesn't work!

@kbhawkey
Copy link
Contributor

kbhawkey commented Nov 1, 2019

hello @alexcontini . How do the new style settings relate to the values set in assets/sass_case-studies.sass, assets/style.sass?
Would it be helpful to create a meaningful name to describe the new style design (for example: case-studies-bold-banner)? The name would reflect this set of case studies. I don't find the date informative.

@alexcontini
Copy link
Contributor Author

@kbhawkey it's just an updated design for the case studies, so instead of having to use blue images, we can use black and white and there is a gradient overlay added. There are also a lot of spacing modifications, new stat section and the design is simplified overall. So there is nothing specific besides the fact that it's an updated design...

Maybe we could call it case-studies-gradient or something like that?

@kbhawkey
Copy link
Contributor

kbhawkey commented Nov 1, 2019

@kbhawkey it's just an updated design for the case studies, so instead of having to use blue images, we can use black and white and there is a gradient overlay added. There are also a lot of spacing modifications, new stat section and the design is simplified overall. So there is nothing specific besides the fact that it's an updated design...

Maybe we could call it case-studies-gradient or something like that?

👍

@alexcontini
Copy link
Contributor Author

@kbhawkey I updated the file name, please merge when you have a chance, thank you!


.article * {
position: relative;
/* hack */
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hello @alexcontini . Is there additional follow up work to this PR?
It is hard to evaluate the styling, unless there is an example page using these settings. Just curious, how is line 40 used? Otherwise seems okay. Could use a space on:
line 25: .overlay:before{
line 331: @media screen and (max-width: 580px){

@alexcontini
Copy link
Contributor Author

@kbhawkey - will make those updates for sure, but this is for a new set of case studies, so none of the current ones will be affected.

Is there any way to merge once I make the changes, and then @jkld11 can add another PR with one of the new case studies so we can see how the new styling looks on the preview site?

@kbhawkey
Copy link
Contributor

kbhawkey commented Nov 4, 2019

OK
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 4, 2019
@bradtopol
Copy link
Contributor

assigning @jimangel just to doublecheck this
/assign @jimangel

@bradtopol
Copy link
Contributor

/unassign

Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes are fine by me

@jimangel
Copy link
Member

jimangel commented Nov 7, 2019

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jimangel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 7, 2019
@k8s-ci-robot k8s-ci-robot merged commit 76787f7 into kubernetes:master Nov 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants