Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom args 20191031 #17318

Merged
merged 1 commit into from
Nov 5, 2019
Merged

Custom args 20191031 #17318

merged 1 commit into from
Nov 5, 2019

Conversation

lojies
Copy link
Contributor

@lojies lojies commented Oct 31, 2019

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 31, 2019
@netlify
Copy link

netlify bot commented Oct 31, 2019 •
edited
Loading

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 934df44

https://deploy-preview-17318--kubernetes-io-master-staging.netlify.com

bradtopol
bradtopol reviewed Oct 31, 2019
View reviewed changes
content/en/docs/reference/setup-tools/kubeadm/implementation-details.md Outdated
@@ -202,7 +202,7 @@ Static Pod manifest share a set of common properties:
* If using a local etcd server, `etcd-servers` address will be set to `127.0.0.1:2379`
- Leader election is enabled for both the controller-manager and the scheduler
- Controller-manager and the scheduler will reference kubeconfig files with their respective, unique identities
- All static Pods gets any extra flags specified by the user as described in [passing custom arguments to control plane components](/docs/reference/setup-tools/kubeadm/kubeadm-init/#custom-args)
- All static Pods gets any extra flags specified by the user as described in [passing custom arguments to control plane components](/docs/reference/setup-tools/kubeadm/kubeadm-init/#options)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are you not using /docs/setup/production-environment/tools/kubeadm/control-plane-flags/ instead of docs/reference/setup-tools/kubeadm/kubeadm-init/#options ?

See https://deploy-preview-17318--kubernetes-io-master-staging.netlify.com/docs/setup/production-environment/tools/kubeadm/control-plane-flags/

@bradtopol
Copy link
Contributor

See my inline comment. I think there is a better page to link to.

@bradtopol
Copy link
Contributor

/assign

@lojies lojies force-pushed the custom_args_20191031 branch from cb1480c to 934df44 Compare October 31, 2019 04:35
@lojies
Copy link
Contributor Author

lojies commented Oct 31, 2019

@bradtopol ,thanks for the suggestion and review.I have changed this.

@neolit123
Copy link
Member

/lgtm
/sig cluster-lifecycle

@k8s-ci-robot k8s-ci-robot added sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Oct 31, 2019
bradtopol
bradtopol approved these changes Nov 5, 2019
View reviewed changes
Copy link
Contributor

@bradtopol bradtopol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

@bradtopol
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bradtopol

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 5, 2019
@k8s-ci-robot k8s-ci-robot merged commit e48b869 into kubernetes:master Nov 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bradtopol bradtopol bradtopol approved these changes

@Rajakavitha1 Rajakavitha1 Awaiting requested review from Rajakavitha1

@sftim sftim Awaiting requested review from sftim

Assignees

@neolit123 neolit123

@bradtopol bradtopol

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lojies @bradtopol @neolit123 @k8s-ci-robot