Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update how to run Hugo locally #16982

Merged
merged 1 commit into from
Oct 23, 2019
Merged

Update how to run Hugo locally #16982

merged 1 commit into from
Oct 23, 2019

Conversation

zacharysarah
Copy link
Contributor

@zacharysarah zacharysarah commented Oct 16, 2019 •
edited
Loading

This PR updates intermediate contribution guidelines based on feedback in #16814 (comment).

/assign @aimeeu

Preview link

https://deploy-preview-16982--kubernetes-io-master-staging.netlify.com/docs/contribute/intermediate/#view-your-changes-locally

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 16, 2019
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Oct 16, 2019
@netlify
Copy link

netlify bot commented Oct 16, 2019

Deploy preview for kubernetes-io-master-staging ready!

Built with commit d71f7c0

https://deploy-preview-16982--kubernetes-io-master-staging.netlify.com

@aimeeu
Copy link
Contributor

aimeeu commented Oct 17, 2019

Thanks for the quick PR, @zacharysarah!
@sftim - this looks good to me, but I can't officially leave /lgtm.

@zacharysarah
Copy link
Contributor Author

@zparnold Wrangle on, wrangler! 🤠

sftim
sftim approved these changes Oct 17, 2019
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine by me!
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 17, 2019
@zacharysarah
Copy link
Contributor Author

/assign @bradtopol

@zparnold
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zparnold

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 23, 2019
@k8s-ci-robot k8s-ci-robot merged commit b894856 into kubernetes:master Oct 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sftim sftim sftim approved these changes

@Rajakavitha1 Rajakavitha1 Awaiting requested review from Rajakavitha1

Assignees

@bradtopol bradtopol

@sftim sftim

@aimeeu aimeeu

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@zacharysarah @aimeeu @zparnold @k8s-ci-robot @sftim @bradtopol