Update 1.14 to Hugo 0.57.2

[zacharysarah]

This is the 1.14 version of #16104.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign zacharysarah
You can assign the PR to them by writing /assign @zacharysarah in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[zacharysarah]

Error: Error building site: "/opt/build/repo/content/en/docs/tutorials/clusters/apparmor.md:126:1": failed to render shortcode "capture": failed to process shortcode: "/opt/build/repo/layouts/shortcodes/code.html:14:16": execute of template failed: template: shortcodes/code.html:14:16: executing "shortcodes/code.html" at <readFile $filename>: error calling readFile: runtime error: invalid memory address or nil pointer dereference

shortcodes/code.html is identical in master and release-1.14.
/shrug

[kbhawkey]

Error: Error building site: "/opt/build/repo/content/en/docs/tutorials/clusters/apparmor.md:126:1": failed to render shortcode "capture": failed to process shortcode: "/opt/build/repo/layouts/shortcodes/code.html:14:16": execute of template failed: template: shortcodes/code.html:14:16: executing "shortcodes/code.html" at <readFile $filename>: error calling readFile: runtime error: invalid memory address or nil pointer dereference

shortcodes/code.html is identical in master and release-1.14.
/shrug

hello @zacharysarah, I do not fully understand the problem, but that file has one code shortcode. Will the file compile if you remove the shortcode, or change the shortcode to codenew? Also, does the 0.57.2 version of hugo have an extended version (scss/sass ToCSS)?

[aimeeu]

@zacharysarah

This compile error appears starting with Hugo v0.56.0, which had a lot of changes to the codebase.

In the 1.16 master website code, neither the code nor codenew shortcodes could find deny-write.profile, which was in the same directory as apparmor.md (I tried several different things). To compile without error in Hugo v0.56+, I created a new directory:
content/en/examples/tutorials/clusters

Then moved deny-write.profile from content/en/docs/tutorials/clusters to the new directory since codenew looks for files in examples.

Finally I changed content/en/docs/tutorials/clusters/apparmor.md line 181 to use the codenew shortcode:
{{< codenew language="text" file="tutorials/clusters/deny-write.profile" >}}

Replicating this in the release-1.14 branch eliminates the compile error. However, in PR #16531, tengq replaces the shortcode in L181 with the contents of the deny-write.profile file, so I think it would be easier to cherry pick that change to earlier branches.

However, part deux:
I'm now getting a different compile error with 1.14 and Hugo v0.57.2:
Error: Error building site: "/home/aimee/Dev/git/github.com/aimeeu/k8s/1.14/website/content/en/blog/_posts/2018-10-18-tips-for-first-kubecon-presentation-part-1.md:1:1": timed out initializing value. This is most likely a circular loop in a shortcode

The only shortcode in the blog post is {{< tweet >}}. This article explains under what circumstances the error is thrown and how to avoid it (increase timeout or store tweet json locally). Increasing the timeout value in config.toml eliminated the error on my local environment; most likely not needed in CI/CD environment. Now 1.14 compiles under Hugo 0.57.2. However, part 3: The blog R menu - the year doesn't expand/collapse when I click on it (Firefox 69, Chromium 76 on Ubuntu 18)

[zacharysarah]

Closing/reopening this PR due to merge wonkiness.

[zacharysarah]

/close

[k8s-ci-robot]

@zacharysarah: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.