Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove non-member approver from PT content #15676

Merged
merged 1 commit into from
Aug 5, 2019

Conversation

zacharysarah
Copy link
Contributor

@zacharysarah zacharysarah commented Aug 5, 2019

This PR removes @devlware as an approver for Portuguese content.

See #15131 (comment) for context, which also specifies conditions for re-adding @devlware.

TLDR: @devlware needs to be an org member first.

This PR needs fast approval because it's blocking the 1.16 release cycle. #15656
EDIT: It's also blocking the Portuguese l10n cycle: #15655

/sig docs
/priority critical-urgent
/assign @jimangel

@k8s-ci-robot k8s-ci-robot added sig/docs Categorizes an issue or PR as relevant to SIG Docs. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 5, 2019
@k8s-ci-robot k8s-ci-robot requested review from jimangel and sftim August 5, 2019 21:20
@netlify
Copy link

netlify bot commented Aug 5, 2019

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 0a1486c

https://deploy-preview-15676--kubernetes-io-master-staging.netlify.com

@jimangel
Copy link
Member

jimangel commented Aug 5, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 5, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jimangel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 5, 2019
@k8s-ci-robot k8s-ci-robot merged commit 970448f into kubernetes:master Aug 5, 2019
@zacharysarah zacharysarah deleted the remove-pt-approver branch August 5, 2019 22:05
wahyuoi pushed a commit to wahyuoi/website that referenced this pull request Sep 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants