Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix markup for 7/23/2019 blog post #15578

Merged
merged 1 commit into from
Jul 30, 2019

Conversation

zacharysarah
Copy link
Contributor

@zacharysarah zacharysarah commented Jul 30, 2019

This PR fixes broken markup for this blog post.

@JasonHaley 👋 For future reference:

  1. Use site shortcodes for callouts

    Specifically, k/website uses custom shortcodes for callouts:

    {{< note >}}
    No need to include a prefix; the shortcode automatically provides one. (Note:, Caution:, etc.)
    {{< /note >}}
    
  2. Use single backticks for inline code snippets.

    Only use triple backticks for fencing code samples with newlines:

    This is an `inline code sample`.
    

/assign @mrbobbytables @kbarnard10

/area blog

@k8s-ci-robot k8s-ci-robot added area/blog Issues or PRs related to the Kubernetes Blog subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 30, 2019
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Jul 30, 2019
@netlify
Copy link

netlify bot commented Jul 30, 2019

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 1994f35

https://deploy-preview-15578--kubernetes-io-master-staging.netlify.com

@zacharysarah zacharysarah force-pushed the blog-fix branch 2 times, most recently from 7ce0d2a to a8ecb09 Compare July 30, 2019 02:42
Silly rabbit, shortcode spaces matter

Even siller rabbit

Nit
@mrbobbytables
Copy link
Member

/lgtm
Thanks again for finding the root problem and fixing it @zacharysarah !

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 30, 2019
@castrojo
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: castrojo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 30, 2019
@k8s-ci-robot k8s-ci-robot merged commit 39ef9e2 into kubernetes:master Jul 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/blog Issues or PRs related to the Kubernetes Blog subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants