Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zh-trans:/docs/tasks/administer-cluster/running-cloud-controller.md #15400

Merged
merged 1 commit into from
Jul 14, 2019
Merged

zh-trans:/docs/tasks/administer-cluster/running-cloud-controller.md #15400

merged 1 commit into from
Jul 14, 2019

Conversation

MJ-CJM
Copy link

@MJ-CJM MJ-CJM commented Jul 13, 2019

No description provided.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/zh Issues or PRs related to Chinese language size/L Denotes a PR that changes 100-499 lines, ignoring generated files. sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Jul 13, 2019
markthink
markthink reviewed Jul 14, 2019
View reviewed changes
Copy link

@markthink markthink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 14, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markthink

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 14, 2019
@k8s-ci-robot k8s-ci-robot merged commit 8d2fe94 into kubernetes:release-1.14 Jul 14, 2019
@MJ-CJM MJ-CJM mentioned this pull request Aug 27, 2019
Closed
6 tasks
SataQiu pushed a commit to SataQiu/website that referenced this pull request Oct 9, 2019
@MJ-CJM @SataQiu
. (kubernetes#15400)
2bef583
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markthink markthink markthink left review comments

@chenrui333 chenrui333 Awaiting requested review from chenrui333

@zhangxiaoyu-zidif zhangxiaoyu-zidif Awaiting requested review from zhangxiaoyu-zidif

Assignees

@markthink markthink

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/zh Issues or PRs related to Chinese language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MJ-CJM @k8s-ci-robot @markthink