Update contribution guidelines for approvers #15385
Conversation
k8s-ci-robot
added
sig/docs
|
Deploy preview for kubernetes-io-master-staging ready! Built with commit af11da7 https://deploy-preview-15385--kubernetes-io-master-staging.netlify.com |
| @@ -109,13 +109,19 @@ more information about the responsibilities of reviewers and approvers, see | |||
| [style guide](/docs/contribute/style/style-guide). Only people listed as | |||
| approvers in the | |||
| [`OWNERS`](https://github.com/kubernetes/website/blob/master/OWNERS) file can | |||
| approve a PR. To approve a PR, leave an `/approved` comment on the PR. | |||
| approve a PR. To approve a PR, leave an `/approve` comment on the PR. | |||
There was a problem hiding this comment.
line 111: What is the relationship between the OWNERS file and the OWNERS_ALIASES file? Why are both needed?
line 115: Change to, /approve? There are a number of instances of /approved in the page.
There was a problem hiding this comment.
I figured out the OWNERS, OWNERS_ALIASES files.
I will address the nits that I found in a follow on PR.
Thanks!
/approve
k8s-ci-robot
added
the
lgtm
| [PR Wrangler rotation scheduler](https://github.com/kubernetes/website/wiki/PR-Wranglers) | ||
| for weekly rotations. All SIG Docs approvers are expected to take part in this | ||
| for weekly rotations. SIG Docs expects all approvers to participate in this |
There was a problem hiding this comment.
line 225, is it scheduler or schedule?
|
|
||
| A PR is merged when it has both a `/lgtm` comment from anyone in the Kubernetes | ||
| organization and an `/approved` comment from an approver in the | ||
| `sig-docs-maintainers` group, as long as it is not on hold and the PR author | ||
| has signed the CLA. | ||
|
|
||
| {{< note >}} | ||
|
|
||
| The ["Participating"](/docs/contribute/participating/#approvers) section contains more information for reviewers and approvers, including specific responsibilities for approvers. |
There was a problem hiding this comment.
This note seems to be a duplicate of line 98. Is that intentional?
|
LGTM |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kbhawkey The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
This PR updates docs contribution guidelines:
/sig docs
/assign @kbhawkey