Skip to content

Conversation

dgoodwin
Copy link
Contributor

@dgoodwin dgoodwin commented Oct 20, 2016

cc @kubernetes/sig-cluster-lifecycle


This change is Reviewable

Copy link

@pires pires left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jbeda jbeda added Docs LGTM and removed Docs LGTM labels Oct 20, 2016
@@ -112,6 +117,12 @@ to change the DNS name suffix. Again, you will need to update the
`/etc/systemd/system/kubelet.service.d/10-kubeadm.conf` file accordingly else DNS will
not function correctly.

- `--skip-preflight-checks`

By default, 'kubeadm' runs a series of preflight checks to validate the system
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use backticks instead of single quotes around kubeadm. By default, kubeadm runs ...
(3 instances)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My mistake, updated now.

@luxas
Copy link
Member

luxas commented Oct 24, 2016

Needs a rebase yet @dgoodwin

@dgoodwin dgoodwin force-pushed the kubeadm-skip-preflight branch from 76a0a77 to 4fd44b1 Compare October 24, 2016 14:50
@dgoodwin
Copy link
Contributor Author

Rebased.

@luxas
Copy link
Member

luxas commented Oct 24, 2016

LGTM

@luxas luxas merged commit 3aa3ca8 into kubernetes:master Oct 24, 2016
Okabe-Junya pushed a commit to Okabe-Junya/website that referenced this pull request Dec 4, 2023
* [es] Sync contribute index file

Signed-off-by: Victor Morales <chipahuac@hotmail.com>

* Add missing words to the Spanish list

Signed-off-by: Victor Morales <chipahuac@hotmail.com>

Signed-off-by: Victor Morales <chipahuac@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants