Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cycle KubeCon info on landing page #15170

Merged
merged 2 commits into from
Jun 27, 2019
Merged

Cycle KubeCon info on landing page #15170

merged 2 commits into from
Jun 27, 2019

Conversation

zacharysarah
Copy link
Contributor

@zacharysarah zacharysarah commented Jun 27, 2019 •
edited
Loading

This PR updates:

  • KubeCon dates/locations in the buttons on the main page
  • button width to accommodate longer text strings for Amsterdam

/sig docs
/assign @idvoretskyi

@k8s-ci-robot k8s-ci-robot added sig/docs Categorizes an issue or PR as relevant to SIG Docs. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 27, 2019
@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Jun 27, 2019
@netlify
Copy link

netlify bot commented Jun 27, 2019 •
edited
Loading

Deploy preview for kubernetes-io-master-staging ready!

Built with commit c0f899d

https://deploy-preview-15170--kubernetes-io-master-staging.netlify.com

@zacharysarah
Copy link
Contributor Author

/assign @kbarnard10

@kbarnard10
Copy link
Contributor

The buttons are breaking in the preview link. Can you extend the width of that section in the _base.sass file?

@kbarnard10
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 27, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kbarnard10

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 27, 2019
@k8s-ci-robot k8s-ci-robot merged commit c0382f1 into kubernetes:master Jun 27, 2019
@ialidzhikov ialidzhikov mentioned this pull request Jun 29, 2019
Merged
joaovitor pushed a commit to joaovitor/website that referenced this pull request Jul 5, 2019
@zacharysarah @joaovitor
Cycle KubeCon info on landing page (kubernetes#15170)
b3f75c7 
* Cycle KubeCon info on landing page

* Adjust button width
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stewart-yu stewart-yu Awaiting requested review from stewart-yu

@xiangpengzhao xiangpengzhao Awaiting requested review from xiangpengzhao

Assignees

@idvoretskyi idvoretskyi

@kbarnard10 kbarnard10

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zacharysarah @kbarnard10 @k8s-ci-robot @idvoretskyi