Skip to content

Conversation

jbeda
Copy link
Contributor

@jbeda jbeda commented Oct 17, 2016

  • Link from "getting started" to full reference docs
  • Document how to do "one phase" automation of kubeadm
  • Document kubeadm env variables.

This change is Reviewable

@@ -13,6 +13,8 @@ The installation uses a tool called `kubeadm` which is part of Kubernetes 1.4.
This process works with local VMs, physical servers and/or cloud servers.
It is simple enough that you can easily integrate its use into your own automation (Terraform, Chef, Puppet, etc).

The full reference for `kubeadm` is [here](/docs/admin/kubeadm/). Please refer to that for all of the command line flags and advice for automating `kubeadm` itself.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are two links on this page to the reference.
If you're convinced that we need a third, it's fine for me, otherwise move or remove

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heh -- I only see one other link. When I wrote this I wasn't completely up to date and missed that it was already there. I think the link could be more prominent but happy to remove this if you like.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"See the full kubeadm reference for information on all kubeadm command-line flags and for advice on automating kubeadm itself."

@luxas
Copy link
Member

luxas commented Oct 17, 2016

I'm going on a journey to London the rest of the week, so can't review it

Reassigning to @errordeveloper

Also cc @kubernetes/sig-cluster-lifecycle

@@ -127,8 +139,8 @@ for a full list of available versions).

### `kubeadm join`

`kubeadm join` has one mandatory flag, the token used to secure cluster bootstrap,
and one mandatory argument, the master IP address.
`kubeadm join` has one mandatory flag, the token used to secure cluster
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commas make this read like a list of four things instead of a list of two things. What's the difference between a flag and an argument?

Suggest a reword: "When you use kubeadm join, you must supply the token used to secure cluster boostrap as a mandatory flag, and the master IP address as a mandatory argument."

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just reflowed the text but happy to make changes here.

@@ -139,6 +151,37 @@ Here's an example on how to use it:
By default, when `kubeadm init` runs, a token is generated and revealed in the output.
That's the token you should use here.

## Automating kubeadm

While most of the tutorials for kubeadm are linear and involve copying the token from `kubeadm init` to each node, you can parallelize this for easier automation. The only requirement is that you know the IP that master will have after it is started.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Rather than copying the token you obtained from kubeadm init to each node, as in the basic kubeadm tutorials, you can parallelize the token distribution for easier automation. To implement this automation, you must know the IP address that the master will have after it is started."

@@ -13,6 +13,8 @@ The installation uses a tool called `kubeadm` which is part of Kubernetes 1.4.
This process works with local VMs, physical servers and/or cloud servers.
It is simple enough that you can easily integrate its use into your own automation (Terraform, Chef, Puppet, etc).

The full reference for `kubeadm` is [here](/docs/admin/kubeadm/). Please refer to that for all of the command line flags and advice for automating `kubeadm` itself.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"See the full kubeadm reference for information on all kubeadm command-line flags and for advice on automating kubeadm itself."

@jbeda
Copy link
Contributor Author

jbeda commented Oct 17, 2016

PTAL

@devin-donnelly
Copy link
Contributor

Docs LGTM. Waiting on tech review.

@jbeda
Copy link
Contributor Author

jbeda commented Oct 20, 2016

Can someone from @kubernetes/sig-cluster-lifecycle give this a review and we can get it merged?

@pires
Copy link

pires commented Oct 20, 2016

Docs LGTM.

@jbeda
Copy link
Contributor Author

jbeda commented Oct 20, 2016

@pires -- can you say "Tech Review LGTM"?

@pires
Copy link

pires commented Oct 20, 2016

Tech Review LGTM

@luxas
Copy link
Member

luxas commented Oct 24, 2016

LGTM, but I can't merge it; it needs a rebase unfortunately

@jbeda
Copy link
Contributor Author

jbeda commented Oct 24, 2016

Rebased. PTAL

@luxas
Copy link
Member

luxas commented Oct 24, 2016

Merging then based on earlier LGTMs

@luxas luxas merged commit 7fc7c2c into kubernetes:master Oct 24, 2016
mikutas pushed a commit to mikutas/k8s-website that referenced this pull request Sep 22, 2022
* Fix kubernetes#1491

`linkerd-base` chart doesn't exist.

Signed-off-by: Adam Gardner <adam.gardner@magicmemories.com>

* Update linkerd.io/content/2.12/tasks/automatically-rotating-control-plane-tls-credentials.md

Co-authored-by: Alejandro Pedraza <alejandro.pedraza@gmail.com>
Signed-off-by: Adam Gardner <adam.gardner@magicmemories.com>

Signed-off-by: Adam Gardner <adam.gardner@magicmemories.com>
Co-authored-by: Alejandro Pedraza <alejandro.pedraza@gmail.com>
Okabe-Junya pushed a commit to Okabe-Junya/website that referenced this pull request Dec 4, 2023
Signed-off-by: Michael <cloudyonspring@126.com>

Signed-off-by: Michael <cloudyonspring@126.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants