Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add content/es/docs/setup/release/building-from-source.md #13818

Closed
wants to merge 3 commits into from
Closed

Add content/es/docs/setup/release/building-from-source.md #13818

wants to merge 3 commits into from

Conversation

seomago
Copy link
Contributor

@seomago seomago commented Apr 15, 2019 •
edited
Loading

building-from-source.md
version en español.
Mi primer PR

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Apr 15, 2019
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. language/es Issues or PRs related to Spanish language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Apr 15, 2019
@netlify
Copy link

netlify bot commented Apr 15, 2019 •
edited
Loading

Deploy preview for kubernetes-io-master-staging ready!

Built with commit f29f130

https://deploy-preview-13818--kubernetes-io-master-staging.netlify.com

@raelga
Copy link
Member

raelga commented Apr 15, 2019

Thanks @seomago for your PR!

First things first, to be able to publish your content, you need to sign the CLA. Please check https://git.k8s.io/community/CLA.md#the-contributor-license-agreement for more information and be sure that you use the same mail account both in the CLA and the git commits.

@seomago
Copy link
Contributor Author

seomago commented Apr 15, 2019

"You have successfully signed your document"

Esto tiene buena pinta

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Apr 15, 2019
@seomago
Copy link
Contributor Author

seomago commented Apr 15, 2019

/lgtm

@k8s-ci-robot
Copy link
Contributor

@seomago: you cannot LGTM your own PR.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@seomago
Copy link
Contributor Author

seomago commented Apr 15, 2019

/approved

@raelga
Copy link
Member

raelga commented Apr 15, 2019 •
edited
Loading

Buenas @seomago, gracias por la aportación!

Los comandos de /lgtm solo responden a reviewers y owners de sig-docs-es y los comandos /approve a los owners. Puedes encontrar el listado en OWNERS_ALIASES.

Sobre los ficheros de la PR, se deberían quitar:

  • _content/es/docs/setup/release/index.md

    Ya se ha creado todo el árbol de índices en otra PR y se añadirá en los próximos días.

  • content/es/docs/setup/release/notes.md

    Este fichero está igual que el original, no es necesario añadirlo ya que por defecto se sirve la versión en inglés.

Por otro lado, ¿puedes repasar la acentuación? Hay varias palabras que deberían acentuarse a lo largo del documento.

Por último, si haces cambios, sería recomendable hacer un squash para que todos los cambios queden contenidos en un solo commit.

Si tienes cualquier duda, me puedes encontrar en slack.

Muchas gracias!

@seomago seomago mentioned this pull request Apr 17, 2019
Closed
@raelga
Copy link
Member

raelga commented Apr 17, 2019

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 17, 2019
raelga
raelga requested changes Apr 17, 2019
View reviewed changes
Copy link
Member

@raelga raelga left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Se deberían quitar los siguientes ficheros de la PR:

_content/es/docs/setup/release/index.md

Ya se ha creado todo el árbol de índices en otra PR.

content/es/docs/setup/release/notes.md

Este fichero está igual que el original, no es necesario añadirlo ya que por defecto se sirve la versión en inglés.

Una vez quitados, haz un squash de todos los commits y déjalo en uno solo.

¡Muchas gracias!

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Apr 18, 2019
@seomago
Copy link
Contributor Author

seomago commented Apr 18, 2019

He quitado index.md y notes.md
(tal y como apunta @raelga )

@raelga
Copy link
Member

raelga commented Apr 18, 2019

Muchas gracias @seomago por quitar los documentos que no formaban parte de la localización.

Mira de hacer un squash para dejar la PR en un solo commit una vez resuelvas las revisiones pendientes.

Para cualquier cosa, estamos en slack.

@raelga raelga changed the title Seomago building from source v2 Add /es/docs/setup/release/building-from-source.md Apr 19, 2019
@raelga raelga self-assigned this Apr 19, 2019
@raelga raelga changed the title Add /es/docs/setup/release/building-from-source.md Add content/es/docs/setup/release/building-from-source.md Apr 22, 2019
proth1 and others added 2 commits April 23, 2019 10:00
@proth1 @seomago
the sentence does not make sense (kubernetes#12673)
115c6aa 
I've attempted to have it make more sense by removing the word 'is'.  Optionally, depending on the intended meaning, the sentence could read differently by leaving the word 'is' alone and changing the word 'through' to 'though'.
@seomago
building-from-source.md
32275d6 
Create _index.md

Create notes.md

Se añaden acentos

Delete notes.md

Delete _index.md

building

Update building-from-source.md

cambio

mas acentos
@seomago seomago force-pushed the seomago-building-from-source-1 branch from e6a258d to 32275d6 Compare April 23, 2019 08:05
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: chenopis

If they are not already assigned, you can assign the PR to them by writing /assign @chenopis in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Apr 23, 2019
@seomago
Copy link
Contributor Author

seomago commented Apr 23, 2019

Ya hice el squash gracias a @raelga

@alexbrand
Copy link
Contributor

Hey @seomago, parece que el PR todavia tiene 2 commits y esta modificando un archivo en ingles.

@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 23, 2019
@seomago
Copy link
Contributor Author

seomago commented Apr 23, 2019

content/en/docs/concepts/services-networking/ingress.md
Vaya la he vuelto a liar....
ahora no se como quitarlo de mi pull request.
Help!!!

@raelga
Copy link
Member

raelga commented Apr 23, 2019

@seomago Lo podemos mirar por slack de nuevo.

And as @alexbrand said, you need to drop the commit that removes the english file and update again the PR.

@seomago seomago mentioned this pull request Apr 24, 2019
Merged
@seomago
Copy link
Contributor Author

seomago commented Apr 24, 2019

#14007
he vuelto a hacer un nuevo PR aqui
Se que lo voy a conseguir aunque me esta costando un poco!!!!!

@seomago seomago closed this Apr 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sftim sftim sftim left review comments

@electrocucaracha electrocucaracha electrocucaracha left review comments

@raelga raelga raelga requested changes

@alexbrand alexbrand alexbrand requested changes

Assignees

@raelga raelga

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. language/en Issues or PRs related to English language language/es Issues or PRs related to Spanish language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@seomago @k8s-ci-robot @raelga @alexbrand @electrocucaracha @sftim @proth1