Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pod pid limit #13806

Closed
wants to merge 1 commit into from
Closed

Conversation

derekwaynecarr
Copy link
Member

Follow-up from #13006

Had got lost in a sea of github notifications.

This is for 1.14.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 12, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: tfogo

If they are not already assigned, you can assign the PR to them by writing /assign @tfogo in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Apr 12, 2019

If enabled, the `kubelet` argument for `pod-max-pids` will write out the configured
pid limit to the pod level cgroup to the value specified on Linux hosts. If -1,
the `kubelet` will default to the node allocatable pid capacity.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to add some words to explicitly show that the default value of pod-max-pids is -1?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a special meaning for 0 too? is 0 == no limit?


## Pod to Pod Isolation of Pids

The `SupportPodPidsLimit` feature gate is *beta*.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we make use of a feature-state shortcode here?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And also mention that it's enabled by default in beta?

@DanyC97
Copy link
Contributor

DanyC97 commented Apr 23, 2019

/language en

@derekmahar any chance you can address the comments please?
looking at what @PatrickLang wrote in the issue i think is pretty important missing info from the docs which should get in asap.

@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Apr 23, 2019
@derekmahar
Copy link
Contributor

/language en

@derekmahar any chance you can address the comments please?
looking at what @PatrickLang wrote in the issue i think is pretty important missing info from the docs which should get in asap.

I think you may be confusing me with someone else. I haven't contributed any code or documentation to this project.

@Rajakavitha1
Copy link
Contributor

@derekwaynecarr any chance you can address the comments please?
looking at what @PatrickLang wrote in the issue i think is pretty important missing info from the docs which should get in asap.

@DanyC97
Copy link
Contributor

DanyC97 commented May 12, 2019

/language en
@derekmahar any chance you can address the comments please?
looking at what @PatrickLang wrote in the issue i think is pretty important missing info from the docs which should get in asap.

I think you may be confusing me with someone else. I haven't contributed any code or documentation to this project.

sorry, made a typo in tagging the right person.

@bradtopol
Copy link
Contributor

Hi @derekwaynecarr will there be any progress on this soon? Otherwise I plan to close this. you can always let us know and we can reopen. But if I dont hear from you soon Im closing it. Thanks

@kbhawkey
Copy link
Contributor

Hi, @derekwaynecarr. Closing this PR due to inactivity. Feel free to reopen.
/close

@k8s-ci-robot
Copy link
Contributor

@kbhawkey: Closed this PR.

In response to this:

Hi, @derekwaynecarr. Closing this PR due to inactivity. Feel free to reopen.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants