-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pod pid limit #13806
Pod pid limit #13806
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
||
If enabled, the `kubelet` argument for `pod-max-pids` will write out the configured | ||
pid limit to the pod level cgroup to the value specified on Linux hosts. If -1, | ||
the `kubelet` will default to the node allocatable pid capacity. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to add some words to explicitly show that the default value of pod-max-pids
is -1
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a special meaning for 0
too? is 0 == no limit?
|
||
## Pod to Pod Isolation of Pids | ||
|
||
The `SupportPodPidsLimit` feature gate is *beta*. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we make use of a feature-state
shortcode here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And also mention that it's enabled by default in beta?
/language en @derekmahar any chance you can address the comments please? |
I think you may be confusing me with someone else. I haven't contributed any code or documentation to this project. |
@derekwaynecarr any chance you can address the comments please? |
sorry, made a typo in tagging the right person. |
Hi @derekwaynecarr will there be any progress on this soon? Otherwise I plan to close this. you can always let us know and we can reopen. But if I dont hear from you soon Im closing it. Thanks |
Hi, @derekwaynecarr. Closing this PR due to inactivity. Feel free to reopen. |
@kbhawkey: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Follow-up from #13006
Had got lost in a sea of github notifications.
This is for 1.14.