Skip to content

Conversation

bboreham
Copy link
Contributor

@bboreham bboreham commented Oct 4, 2016

Change kubeadm instructions to show use of sock-shop namespace rather than default.

Background: the demo installs a DefaultDeny network policy annotation, which is tripping up some users who go on to create some more pods without removing the annotation. This change matches microservices-demo/microservices-demo#339 which moves the whole demo out of the default namespace.

This change should not be merged until the microservices-demo change is merged.

CC @errordeveloper


This change is Reviewable

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

Change instructions to show use of 'sock-shop' namespace rather than default.
@bboreham bboreham force-pushed the kubeadm-sample-namespace branch from 9c2314e to c848bf0 Compare October 4, 2016 12:12
@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes and removed cla: no labels Oct 4, 2016
@bboreham
Copy link
Contributor Author

bboreham commented Oct 5, 2016

I signed a CNCF CLA as bryan@weave.works

The upstream change to the demo app is now merged so would be good to get this through.

@lukemarsden
Copy link
Contributor

LGTM

@luxas PTAL

@luxas
Copy link
Member

luxas commented Oct 5, 2016

LGTM

@luxas luxas merged commit 6642fbb into kubernetes:master Oct 5, 2016
mikutas pushed a commit to mikutas/k8s-website that referenced this pull request Sep 22, 2022
Signed-off-by: Christian Mejlak <chris@mejlak.com>
Okabe-Junya pushed a commit to Okabe-Junya/website that referenced this pull request Dec 4, 2023
Signed-off-by: Victor Morales <chipahuac@hotmail.com>
Okabe-Junya pushed a commit to Okabe-Junya/website that referenced this pull request Dec 4, 2023
Signed-off-by: Victor Morales <chipahuac@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants