Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a blog label, update blog OWNERS #13645

Merged
merged 1 commit into from
Apr 9, 2019

Conversation

zacharysarah
Copy link
Contributor

The K8s blog is now an official subproject of SIG Docs. This PR configures tooling in support of the blog as a distinct subproject.

This PR specifies an automatic label for PRs opened against blog content: area/blog (kubernetes/test-infra#12098).

This PR also updates the blog-specific OWNERS file, with the understanding that additional changes are coming.

/assign @kbarnard10
/cc @parispittman @jaredbhatti @Bradamant3

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. labels Apr 5, 2019
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zacharysarah: 1 invalid OWNERS file

In response to this:

The K8s blog is now an official subproject of SIG Docs. This PR configures tooling in support of the blog as a distinct subproject.

This PR specifies an automatic label for PRs opened against blog content: area/blog (kubernetes/test-infra#12098).

This PR also updates the blog-specific OWNERS file, with the understanding that additional changes are coming.

/assign @kbarnard10
/cc @parispittman @jaredbhatti @Bradamant3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

- bobsky
- natekartchner
- sarahkconway

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cannot parse file: error converting YAML to JSON: yaml: line 15: did not find expected '-' indicator.

@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Apr 5, 2019
@zacharysarah zacharysarah force-pushed the blog-label-and-OWNERS branch from 20982b9 to afd30b3 Compare April 5, 2019 22:52
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Apr 5, 2019
@zacharysarah zacharysarah changed the title Add a blog label, update blog OWNERS [WIP] Add a blog label, update blog OWNERS Apr 5, 2019
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 5, 2019
@netlify
Copy link

netlify bot commented Apr 5, 2019

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 20982b9

https://deploy-preview-13645--kubernetes-io-master-staging.netlify.com

@netlify
Copy link

netlify bot commented Apr 5, 2019

Deploy preview for kubernetes-io-master-staging ready!

Built with commit afd30b3

https://deploy-preview-13645--kubernetes-io-master-staging.netlify.com

@zacharysarah zacharysarah changed the title [WIP] Add a blog label, update blog OWNERS Add a blog label, update blog OWNERS Apr 6, 2019
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 6, 2019
@zacharysarah
Copy link
Contributor Author

Holding for kubernetes/test-infra#12098 to merge.

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 6, 2019
@@ -1,11 +1,17 @@
# See the OWNERS docs at https://go.k8s.io/owners

# Owned by Kubernetes Blog reviewers.
# Owned by Kubernetes Blog reviewers

options:
no_parent_owners: false
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no_parent_owners is false by default, so this isn't really needed :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nikhita 👋 There’s an open discussion about whether to reenable it in the next couple months. For now, it’s handy to have around—and we can always remove it in a separate PR.

@zacharysarah
Copy link
Contributor Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 7, 2019
@tengqm
Copy link
Contributor

tengqm commented Apr 9, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 9, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 9, 2019
@k8s-ci-robot k8s-ci-robot merged commit a2e9766 into kubernetes:master Apr 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants