-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update config.toml #13406
Update config.toml #13406
Conversation
updating old docs to reference 1.14, updating minor version numbers, and dropping 1.9.
@lucperkins 👋 We'd love your input here. For context: when we release a new version of the docs, we have to update the version selector in the previous four release branches. This requires four separate PRs to update This PR (on Hugo v0.53) is failing. Release 1.12 docs (on Hugo v0.49) continue to display the deprecation warning correctly. As near as @jimangel and I can tell, this PR may be failing due to changes introduced in #12079, specifically to syntax changes in the deprecation warning. 3:46:10 PM: ERROR 2019/03/25 22:46:10 "/opt/build/repo/content/ko/_index.html:7:1": failed to render shortcode "deprecationwarning": failed to process shortcode: "/opt/build/repo/layouts/shortcodes/deprecationwarning.html:6:16": execute of template failed: template: shortcodes/deprecationwarning.html:6:16: executing "shortcodes/deprecationwarning.html" at <.Param>: can't evaluate field Param in type *hugolib.ShortcodeWithPage
3:46:10 PM: ERROR 2019/03/25 22:46:10 "/opt/build/repo/content/ja/_index.html:7:1": failed to render shortcode "deprecationwarning": failed to process shortcode: "/opt/build/repo/layouts/shortcodes/deprecationwarning.html:6:16": execute of template failed: template: shortcodes/deprecationwarning.html:6:16: executing "shortcodes/deprecationwarning.html" at <.Param>: can't evaluate field Param in type *hugolib.ShortcodeWithPage
3:46:10 PM: ERROR 2019/03/25 22:46:10 "/opt/build/repo/content/fr/_index.html:7:1": failed to render shortcode "deprecationwarning": failed to process shortcode: "/opt/build/repo/layouts/shortcodes/deprecationwarning.html:6:16": execute of template failed: template: shortcodes/deprecationwarning.html:6:16: executing "shortcodes/deprecationwarning.html" at <.Param>: can't evaluate field Param in type *hugolib.ShortcodeWithPage
3:46:10 PM: ERROR 2019/03/25 22:46:10 "/opt/build/repo/content/it/_index.html:7:1": failed to render shortcode "deprecationwarning": failed to process shortcode: "/opt/build/repo/layouts/shortcodes/deprecationwarning.html:6:16": execute of template failed: template: shortcodes/deprecationwarning.html:6:16: executing "shortcodes/deprecationwarning.html" at <.Param>: can't evaluate field Param in type *hugolib.ShortcodeWithPage
3:46:10 PM: Total in 13696 ms
3:46:10 PM: Error: Error building site: "/opt/build/repo/content/en/_index.html:7:1": failed to render shortcode "deprecationwarning": failed to process shortcode: "/opt/build/repo/layouts/shortcodes/deprecationwarning.html:6:16": execute of template failed: template: shortcodes/deprecationwarning.html:6:16: executing "shortcodes/deprecationwarning.html" at <.Param>: can't evaluate field Param in type *hugolib.ShortcodeWithPage |
/cc @seokho-son too as this could also be related to this PR: #12418 As the original CI tests would pass (since master isn't "deprecated") and fail on build as we sunset 1.13 docs (toggling to deprecated, which triggers the notice.html build). I think we need to look very closely at what all is involved when https://github.com/seokho-son/website/blob/9a4e86dd5da30859bf9bc36d0975bd676c7b2251/layouts/shortcodes/deprecationwarning.html is generated. |
wow, never thought that is the process today, ouch |
@zacharysarah @lucperkins @seokho-son I think I see what is needed: s/.Param/.Page.Param/ on line 6 Adding to this PR now... |
Deploy preview for k8s-v1-13 ready! Built with commit 84768f5 |
@jimangel Thanks for your work here! Unrelated to this PR, I have a nit with the wording of the deprecation warning itself. I'm noting it here for reference in a follow-up PR. /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zacharysarah The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
updating old docs to reference 1.14, updating minor version numbers, and dropping 1.9.