Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update config.toml #13406

Merged
merged 2 commits into from
Mar 26, 2019
Merged

Update config.toml #13406

merged 2 commits into from
Mar 26, 2019

Conversation

jimangel
Copy link
Member

updating old docs to reference 1.14, updating minor version numbers, and dropping 1.9.

updating old docs to reference 1.14, updating minor version numbers, and dropping 1.9.
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 25, 2019
@zacharysarah
Copy link
Contributor

zacharysarah commented Mar 26, 2019

@lucperkins 👋 We'd love your input here.

For context: when we release a new version of the docs, we have to update the version selector in the previous four release branches. This requires four separate PRs to update config.toml in the respective release branches.

This PR (on Hugo v0.53) is failing. Release 1.12 docs (on Hugo v0.49) continue to display the deprecation warning correctly.

As near as @jimangel and I can tell, this PR may be failing due to changes introduced in #12079, specifically to syntax changes in the deprecation warning.

3:46:10 PM: ERROR 2019/03/25 22:46:10 "/opt/build/repo/content/ko/_index.html:7:1": failed to render shortcode "deprecationwarning": failed to process shortcode: "/opt/build/repo/layouts/shortcodes/deprecationwarning.html:6:16": execute of template failed: template: shortcodes/deprecationwarning.html:6:16: executing "shortcodes/deprecationwarning.html" at <.Param>: can't evaluate field Param in type *hugolib.ShortcodeWithPage
3:46:10 PM: ERROR 2019/03/25 22:46:10 "/opt/build/repo/content/ja/_index.html:7:1": failed to render shortcode "deprecationwarning": failed to process shortcode: "/opt/build/repo/layouts/shortcodes/deprecationwarning.html:6:16": execute of template failed: template: shortcodes/deprecationwarning.html:6:16: executing "shortcodes/deprecationwarning.html" at <.Param>: can't evaluate field Param in type *hugolib.ShortcodeWithPage
3:46:10 PM: ERROR 2019/03/25 22:46:10 "/opt/build/repo/content/fr/_index.html:7:1": failed to render shortcode "deprecationwarning": failed to process shortcode: "/opt/build/repo/layouts/shortcodes/deprecationwarning.html:6:16": execute of template failed: template: shortcodes/deprecationwarning.html:6:16: executing "shortcodes/deprecationwarning.html" at <.Param>: can't evaluate field Param in type *hugolib.ShortcodeWithPage
3:46:10 PM: ERROR 2019/03/25 22:46:10 "/opt/build/repo/content/it/_index.html:7:1": failed to render shortcode "deprecationwarning": failed to process shortcode: "/opt/build/repo/layouts/shortcodes/deprecationwarning.html:6:16": execute of template failed: template: shortcodes/deprecationwarning.html:6:16: executing "shortcodes/deprecationwarning.html" at <.Param>: can't evaluate field Param in type *hugolib.ShortcodeWithPage
3:46:10 PM: Total in 13696 ms
3:46:10 PM: Error: Error building site: "/opt/build/repo/content/en/_index.html:7:1": failed to render shortcode "deprecationwarning": failed to process shortcode: "/opt/build/repo/layouts/shortcodes/deprecationwarning.html:6:16": execute of template failed: template: shortcodes/deprecationwarning.html:6:16: executing "shortcodes/deprecationwarning.html" at <.Param>: can't evaluate field Param in type *hugolib.ShortcodeWithPage

@jimangel jimangel mentioned this pull request Mar 26, 2019
@jimangel
Copy link
Member Author

/cc @seokho-son too as this could also be related to this PR: #12418

As the original CI tests would pass (since master isn't "deprecated") and fail on build as we sunset 1.13 docs (toggling to deprecated, which triggers the notice.html build).

I think we need to look very closely at what all is involved when https://github.com/seokho-son/website/blob/9a4e86dd5da30859bf9bc36d0975bd676c7b2251/layouts/shortcodes/deprecationwarning.html is generated.

@DanyC97
Copy link
Contributor

DanyC97 commented Mar 26, 2019

we have to update the version selector in the previous four release branches. This requires four separate PRs to update config.toml in the respective release branches.

wow, never thought that is the process today, ouch

@jimangel
Copy link
Member Author

@zacharysarah @lucperkins @seokho-son I think I see what is needed:

s/.Param/.Page.Param/ on line 6

Adding to this PR now...

@netlify
Copy link

netlify bot commented Mar 26, 2019

Deploy preview for k8s-v1-13 ready!

Built with commit 84768f5

https://deploy-preview-13406--k8s-v1-13.netlify.com

@zacharysarah
Copy link
Contributor

@jimangel Thanks for your work here!

Unrelated to this PR, I have a nit with the wording of the deprecation warning itself. I'm noting it here for reference in a follow-up PR.

Screen Shot 2019-03-26 at 12 49 16 PM

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 26, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zacharysarah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 26, 2019
@k8s-ci-robot k8s-ci-robot merged commit 16d47a2 into release-1.13 Mar 26, 2019
jimangel added a commit that referenced this pull request Mar 26, 2019
@jimangel jimangel deleted the jimangel-patch-3 branch March 26, 2019 20:04
k8s-ci-robot pushed a commit that referenced this pull request Mar 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants