Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update PULL_REQUEST_TEMPLATE to include ko-i18n info #11720

Merged
merged 2 commits into from
Jan 4, 2019

Conversation

gochist
Copy link
Member

@gochist gochist commented Dec 12, 2018

Added base branch guide for ko l10n in the PULL_REQUEST_TEMPLATE.
This is related with #11652

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 12, 2018
@k8sio-netlify-preview-bot
Copy link
Collaborator

k8sio-netlify-preview-bot commented Dec 12, 2018

Deploy preview for kubernetes-io-master-staging ready!

Built with commit ae0f668

https://deploy-preview-11720--kubernetes-io-master-staging.netlify.com

@gochist
Copy link
Member Author

gochist commented Dec 13, 2018

@ianychoi @claudiajkang Please review Korean message.

@claudiajkang
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 13, 2018
@gochist
Copy link
Member Author

gochist commented Dec 13, 2018

/assign @tfogo
Please take a look

@tengqm
Copy link
Contributor

tengqm commented Dec 17, 2018

Generally lgtm, but I'm not sure if we are supposed to add non-English text into the template. They are visible to all contributors and may cause mental upset, :).

@gochist
Copy link
Member Author

gochist commented Dec 17, 2018

@tengqm I think it will be fine because this community is open minded enough. How about discussing about this in the next weekly meeting?

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 19, 2018
@gochist
Copy link
Member Author

gochist commented Dec 19, 2018

@tengqm 👋 I removed non-English text from the template.

@Bradamant3
Copy link
Contributor

@gochist I agree that the community is probably open-minded enough for non-English text. But ... we get a fair number of first-time English-only contributors who don't really become part of the larger k8s or docs communities, and I'm not so sure about them. I suspect that @tengqm's caution is the right way to go. Thanks for updating!

@Bradamant3
Copy link
Contributor

(leaving for docs release leads to finish wrangling)

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 19, 2018
@Bradamant3
Copy link
Contributor

/assign @jimangel for approve

@k8s-ci-robot
Copy link
Contributor

@Bradamant3: GitHub didn't allow me to assign the following users: for, approve.

Note that only kubernetes members and repo collaborators can be assigned.
For more information please see the contributor guide

In response to this:

/assign @jimangel for approve

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gochist
Copy link
Member Author

gochist commented Dec 19, 2018

@Bradamant3 @tengqm Thank you for your kindness!

@jimangel
Copy link
Member

jimangel commented Jan 2, 2019

/lgtm
/approve

@gochist
Copy link
Member Author

gochist commented Jan 4, 2019

@jimangel Thank you! Could you please approve this again?

@jimangel
Copy link
Member

jimangel commented Jan 4, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jimangel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 4, 2019
@k8s-ci-robot k8s-ci-robot merged commit 7c00d0d into kubernetes:master Jan 4, 2019
immutableT pushed a commit to immutableT/website that referenced this pull request Jan 9, 2019
* update PULL_REQUEST_TEMPLATE to include ko-i18n info

* Remove non-English text from the template
immutableT pushed a commit to immutableT/website that referenced this pull request Jan 9, 2019
* update PULL_REQUEST_TEMPLATE to include ko-i18n info

* Remove non-English text from the template
bsalamat pushed a commit to bsalamat/kubernetes.github.io that referenced this pull request Jan 29, 2019
* update PULL_REQUEST_TEMPLATE to include ko-i18n info

* Remove non-English text from the template
@gochist gochist mentioned this pull request Mar 18, 2019
@gochist gochist deleted the pr-template branch September 22, 2019 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants