update PULL_REQUEST_TEMPLATE to include ko-i18n info #11720
Conversation
k8s-ci-robot
added
size/XS
|
Deploy preview for kubernetes-io-master-staging ready! Built with commit ae0f668 https://deploy-preview-11720--kubernetes-io-master-staging.netlify.com |
|
@ianychoi @claudiajkang Please review Korean message. |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/assign @tfogo |
|
Generally lgtm, but I'm not sure if we are supposed to add non-English text into the template. They are visible to all contributors and may cause mental upset, :). |
|
@tengqm I think it will be fine because this community is open minded enough. How about discussing about this in the next weekly meeting? |
k8s-ci-robot
removed
the
lgtm
|
@tengqm 👋 I removed non-English text from the template. |
|
@gochist I agree that the community is probably open-minded enough for non-English text. But ... we get a fair number of first-time English-only contributors who don't really become part of the larger k8s or docs communities, and I'm not so sure about them. I suspect that @tengqm's caution is the right way to go. Thanks for updating! |
|
(leaving for docs release leads to finish wrangling) /lgtm |
k8s-ci-robot
added
the
lgtm
|
/assign @jimangel for approve |
|
@Bradamant3: GitHub didn't allow me to assign the following users: for, approve. Note that only kubernetes members and repo collaborators can be assigned. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@Bradamant3 @tengqm Thank you for your kindness! |
|
/lgtm |
|
@jimangel Thank you! Could you please approve this again? |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jimangel The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
* update PULL_REQUEST_TEMPLATE to include ko-i18n info * Remove non-English text from the template
* update PULL_REQUEST_TEMPLATE to include ko-i18n info * Remove non-English text from the template
* update PULL_REQUEST_TEMPLATE to include ko-i18n info * Remove non-English text from the template
Added base branch guide for ko l10n in the
PULL_REQUEST_TEMPLATE.This is related with #11652